database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-27 23:21:58 +03:00
Code Activity

Remove xmlCleanupParser calls from contrib/xml2.

Browse Source 
These are unnecessary and probably dangerous.  I don't see any immediate
risk situations in the core XML support or contrib/xml2 itself, but there
could be issues with external uses of libxml2, and in any case it's an
accident waiting to happen.
This commit is contained in:
Tom Lane
2010-03-01 05:16:40 +00:00
parent 8748dc3580
commit 5ea32f560a
2 changed files with 6 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/xml2/xslt_proc.c
View File

@ -1,5 +1,5 @@
/*
* $PostgreSQL: pgsql/contrib/xml2/xslt_proc.c,v 1.15.2.2 2010/03/01 03:41:04 tgl Exp $
* $PostgreSQL: pgsql/contrib/xml2/xslt_proc.c,v 1.15.2.3 2010/03/01 05:16:40 tgl Exp $
*
* XSLT processing functions (requiring libxslt)
*
@ -79,7 +79,6 @@ xslt_process(PG_FUNCTION_ARGS)
if (doctree == NULL)
{
xmlCleanupParser();
elog_error("error parsing XML document", false);
PG_RETURN_NULL();
@ -93,7 +92,6 @@ xslt_process(PG_FUNCTION_ARGS)
if (ssdoc == NULL)
{
xmlFreeDoc(doctree);
xmlCleanupParser();
elog_error("error parsing stylesheet as XML document", false);
PG_RETURN_NULL();
}
@ -108,7 +106,6 @@ xslt_process(PG_FUNCTION_ARGS)
{
xmlFreeDoc(doctree);
xsltCleanupGlobals();
xmlCleanupParser();
elog_error("failed to parse stylesheet", false);
PG_RETURN_NULL();
}
@ -121,7 +118,6 @@ xslt_process(PG_FUNCTION_ARGS)
xmlFreeDoc(doctree);
xsltCleanupGlobals();
xmlCleanupParser();
if (resstat < 0)
PG_RETURN_NULL();