database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-05 07:21:24 +03:00
Code Activity

Focus on ftello result < 0 instead of errno

Browse Source 
Rather than reset errno (or just hope that its cleared already),
check just the result of the ftello for < 0 to determine if there
was an issue.

Oversight by me, pointed out by Tom.
This commit is contained in:
Stephen Frost
2014-02-09 13:29:36 -05:00
parent 8198a321c9
commit 5e8e794e3b
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/bin/pg_dump/pg_backup_custom.c
View File

@ -708,7 +708,7 @@ _CloseArchive(ArchiveHandle *AH)
{ {
WriteHead(AH); WriteHead(AH);
tpos = ftello(AH->FH); tpos = ftello(AH->FH);
if (tpos < 0 || errno) if (tpos < 0)
exit_horribly(modulename, "could not determine seek position in archive file: %s\n", exit_horribly(modulename, "could not determine seek position in archive file: %s\n",
strerror(errno)); strerror(errno));
WriteToc(AH); WriteToc(AH);
@ -757,9 +757,8 @@ _ReopenArchive(ArchiveHandle *AH)
if (!ctx->hasSeek) if (!ctx->hasSeek)
exit_horribly(modulename, "parallel restore from non-seekable file is not supported\n"); exit_horribly(modulename, "parallel restore from non-seekable file is not supported\n");
errno = 0;
tpos = ftello(AH->FH); tpos = ftello(AH->FH);
if (tpos < 0 || errno) if (tpos < 0)
exit_horribly(modulename, "could not determine seek position in archive file: %s\n", exit_horribly(modulename, "could not determine seek position in archive file: %s\n",
strerror(errno)); strerror(errno));