database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-06 19:59:18 +03:00
Code

Change example in pgindent README on "/*-----" comments.

Browse Source 
Most, but not all, of our "/*----" style comments have an end-guard
line with dashes at the end of the comment. However, pgindent doesn't
care about the end-guards, so they mostly just waste screen
space. Going forward, let's not require end-guards.

Remove a broken end-guard in a comment in walsender.c that led me to
think about this. Remove the end guard from another comment in
walsender.c for consistency, so that we use the same style in all
comments in the file.

However, we have thousands of existing "/*----" comments the repository,
so it's not worth the code churn to change them all.

Discussion: https://www.postgresql.org/message-id/fb083c91-d490-3b65-25f3-05e9118b6b0d%40iki.fi
This commit is contained in:
Heikki Linnakangas 2023-07-05 10:02:15 +03:00
parent a77d39d5f4
commit 5e8068f04e
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/replication/walsender.c
View File

@ -1197,7 +1197,6 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)
* - second field: LSN at which we became consistent * - second field: LSN at which we became consistent
* - third field: exported snapshot's name * - third field: exported snapshot's name
* - fourth field: output plugin * - fourth field: output plugin
*----------
*/ */
tupdesc = CreateTemplateTupleDesc(4); tupdesc = CreateTemplateTupleDesc(4);
TupleDescInitBuiltinEntry(tupdesc, (AttrNumber) 1, "slot_name", TupleDescInitBuiltinEntry(tupdesc, (AttrNumber) 1, "slot_name",
@ -2692,7 +2691,7 @@ WalSndSegmentOpen(XLogReaderState *state, XLogSegNo nextSegNo,
* restored from the archive on this server, the file belonging to the old * restored from the archive on this server, the file belonging to the old
* timeline, 000000040000000000000013, might not exist. Their contents are * timeline, 000000040000000000000013, might not exist. Their contents are
* equal up to the switchpoint, because at a timeline switch, the used * equal up to the switchpoint, because at a timeline switch, the used
* portion of the old segment is copied to the new file. ------- * portion of the old segment is copied to the new file.
*/ */
*tli_p = sendTimeLine; *tli_p = sendTimeLine;
if (sendTimeLineIsHistoric) if (sendTimeLineIsHistoric)

1
src/tools/pgindent/README
View File

@ -104,7 +104,6 @@ the comment block with some dashes:
/*---------- /*----------
* Text here will not be touched by pgindent. * Text here will not be touched by pgindent.
*----------
*/ */
Odd spacing around typedef names might indicate an incomplete typedefs list. Odd spacing around typedef names might indicate an incomplete typedefs list.