database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-29 13:56:47 +03:00
Code

Wake up for latches in CheckpointWriteDelay().

Browse Source 
The checkpointer shouldn't ignore its latch.  Other backends may be
waiting for it to drain the request queue.  Hopefully real systems don't
have a full queue often, but the condition is reached easily when
shared_buffers is small.

This involves defining a new wait event, which will appear in the
pg_stat_activity view often due to spread checkpoints.

Back-patch only to 14.  Even though the problem exists in earlier
branches too, it's hard to hit there.  In 14 we stopped using signal
handlers for latches on Linux, *BSD and macOS, which were previously
hiding this problem by interrupting the sleep (though not reliably, as
the signal could arrive before the sleep begins; precisely the problem
latches address).

Reported-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220226213942.nb7uvb2pamyu26dj%40alap3.anarazel.de
This commit is contained in:
Thomas Munro 2022-03-16 13:37:58 +13:00
parent a56e7b6601
commit 5e6368b42e
4 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/src/sgml/monitoring.sgml
View File

@ -2235,6 +2235,10 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
<entry><literal>BaseBackupThrottle</literal></entry> <entry><literal>BaseBackupThrottle</literal></entry>
<entry>Waiting during base backup when throttling activity.</entry> <entry>Waiting during base backup when throttling activity.</entry>
</row> </row>
<row>
<entry><literal>CheckpointerWriteDelay</literal></entry>
<entry>Waiting between writes while performing a checkpoint.</entry>
</row>
<row> <row>
<entry><literal>PgSleep</literal></entry> <entry><literal>PgSleep</literal></entry>
<entry>Waiting due to a call to <function>pg_sleep</function> or <entry>Waiting due to a call to <function>pg_sleep</function> or

8
src/backend/postmaster/checkpointer.c
View File

@ -484,6 +484,9 @@ CheckpointerMain(void)
} }
ckpt_active = false; ckpt_active = false;
/* We may have received an interrupt during the checkpoint. */
HandleCheckpointerInterrupts();
} }
/* Check for archive_timeout and switch xlog files if necessary. */ /* Check for archive_timeout and switch xlog files if necessary. */
@ -726,7 +729,10 @@ CheckpointWriteDelay(int flags, double progress)
* Checkpointer and bgwriter are no longer related so take the Big * Checkpointer and bgwriter are no longer related so take the Big
* Sleep. * Sleep.
*/ */
pg_usleep(100000L); WaitLatch(MyLatch, WL_LATCH_SET | WL_EXIT_ON_PM_DEATH | WL_TIMEOUT,
100,
WAIT_EVENT_CHECKPOINT_WRITE_DELAY);
ResetLatch(MyLatch);
} }
else if (--absorb_counter <= 0) else if (--absorb_counter <= 0)
{ {

3
src/backend/utils/activity/wait_event.c
View File

@ -485,6 +485,9 @@ pgstat_get_wait_timeout(WaitEventTimeout w)
case WAIT_EVENT_BASE_BACKUP_THROTTLE: case WAIT_EVENT_BASE_BACKUP_THROTTLE:
event_name = "BaseBackupThrottle"; event_name = "BaseBackupThrottle";
break; break;
case WAIT_EVENT_CHECKPOINT_WRITE_DELAY:
event_name = "CheckpointWriteDelay";
break;
case WAIT_EVENT_PG_SLEEP: case WAIT_EVENT_PG_SLEEP:
event_name = "PgSleep"; event_name = "PgSleep";
break; break;

1
src/include/utils/wait_event.h
View File

@ -141,6 +141,7 @@ typedef enum
typedef enum typedef enum
{ {
WAIT_EVENT_BASE_BACKUP_THROTTLE = PG_WAIT_TIMEOUT, WAIT_EVENT_BASE_BACKUP_THROTTLE = PG_WAIT_TIMEOUT,
WAIT_EVENT_CHECKPOINT_WRITE_DELAY,
WAIT_EVENT_PG_SLEEP, WAIT_EVENT_PG_SLEEP,
WAIT_EVENT_RECOVERY_APPLY_DELAY, WAIT_EVENT_RECOVERY_APPLY_DELAY,
WAIT_EVENT_RECOVERY_RETRIEVE_RETRY_INTERVAL, WAIT_EVENT_RECOVERY_RETRIEVE_RETRY_INTERVAL,