database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-05 07:41:25 +03:00
Code Activity

Avoid unnecessary copying of a string in pg_restore.c

Browse Source 
Coverity complained about a possible overrun in the copy, but there is
no actual need to copy the string at all.
This commit is contained in:
Andrew Dunstan
2025-04-06 09:21:09 -04:00
parent 6d5417e634
commit 5e19154390
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/pg_dump/pg_restore.c
View File

@@ -1052,14 +1052,14 @@ get_dbname_oid_list_from_mfile(const char *dumpdirpath, SimpleOidStringList *dbn
{ {
Oid db_oid = InvalidOid; Oid db_oid = InvalidOid;
char db_oid_str[MAXPGPATH + 1] = ""; char db_oid_str[MAXPGPATH + 1] = "";
char dbname[MAXPGPATH + 1] = ""; char *dbname;
/* Extract dboid. */ /* Extract dboid. */
sscanf(line, "%u", &db_oid); sscanf(line, "%u", &db_oid);
sscanf(line, "%20s", db_oid_str); sscanf(line, "%20s", db_oid_str);
/* Now copy dbname. */ /* dbname is the rest of the line */
strcpy(dbname, line + strlen(db_oid_str) + 1); dbname = line + strlen(db_oid_str) + 1;
/* Remove \n from dbname. */ /* Remove \n from dbname. */
dbname[strlen(dbname) - 1] = '\0'; dbname[strlen(dbname) - 1] = '\0';