database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-16 06:01:02 +03:00
Code Activity

Fix bugs in relpersistence handling during table creation.

Browse Source 
Unlike the relistemp field which it replaced, relpersistence must be
set correctly quite early during the table creation process, as we
rely on it quite early on for a number of purposes, including security
checks.  Normally, this is set based on whether the user enters CREATE
TABLE, CREATE UNLOGGED TABLE, or CREATE TEMPORARY TABLE, but a
relation may also be made implicitly temporary by creating it in
pg_temp.  This patch fixes the handling of that case, and also
disables creation of unlogged tables in temporary tablespace (such
table indeed skip WAL-logging, but we reject an explicit
specification) and creation of relations in the temporary schemas of
other sessions (which is not very sensible, and didn't work right
anyway).

Report by Amit Khandekar.
This commit is contained in:
Robert Haas
2011-07-03 17:34:47 -04:00
parent acb9198b96
commit 5da79169d3
8 changed files with 81 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/commands/tablecmds.c
View File

@ -431,6 +431,13 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId)
(errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("constraints on foreign tables are not supported")));
/*
* Look up the namespace in which we are supposed to create the relation,
* and check we have permission to create there.
*/
namespaceId = RangeVarGetAndCheckCreationNamespace(stmt->relation);
RangeVarAdjustRelationPersistence(stmt->relation, namespaceId);
/*
* Security check: disallow creating temp tables from security-restricted
* code. This is needed because calling code might not expect untrusted
@ -442,12 +449,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId)
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("cannot create temporary table within security-restricted operation")));
/*
* Look up the namespace in which we are supposed to create the relation,
* and check we have permission to create there.
*/
namespaceId = RangeVarGetAndCheckCreationNamespace(stmt->relation);
/*
* Select tablespace to use. If not specified, use default tablespace
* (which may in turn default to database's default).