mirror of
https://github.com/postgres/postgres.git
synced 2025-07-28 23:42:10 +03:00
Rework shutdown callback of archiver modules
As currently designed, with a callback registered in a ERROR_CLEANUP block, the shutdown callback would get called twice when updating archive_library on SIGHUP, which is something that we want to avoid to ease the life of extension writers. Anyway, an ERROR in the archiver process is treated as a FATAL, stopping it immediately, hence there is no need for a ERROR_CLEANUP block. Instead of that, the shutdown callback is not called upon before_shmem_exit(), giving to the modules the opportunity to do any cleanup actions before the server shuts down its subsystems. While on it, this commit adds some testing coverage for the shutdown callback. Neither shell_archive nor basic_archive have been using it, and one is added to shell_archive, whose trigger is checked in a TAP test through a shutdown sequence. Author: Nathan Bossart, Bharath Rupireddy Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13 Backpatch-through: 15
This commit is contained in:
@ -3618,8 +3618,9 @@ include_dir 'conf.d'
|
||||
The library to use for archiving completed WAL file segments. If set to
|
||||
an empty string (the default), archiving via shell is enabled, and
|
||||
<xref linkend="guc-archive-command"/> is used. Otherwise, the specified
|
||||
shared library is used for archiving. For more information, see
|
||||
<xref linkend="backup-archiving-wal"/> and
|
||||
shared library is used for archiving. The WAL archiver process is
|
||||
restarted by the postmaster when this parameter changes. For more
|
||||
information, see <xref linkend="backup-archiving-wal"/> and
|
||||
<xref linkend="archive-modules"/>.
|
||||
</para>
|
||||
<para>
|
||||
|
Reference in New Issue
Block a user