database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Remove logical_read_local_xlog_page

Browse Source 
It devolved into a content-less wrapper over read_local_xlog_page, with
nothing to add, plus it's easily confused with walsender's
logical_read_xlog_page.  There doesn't seem to be any reason for it to
stay.

src/include/replication/logicalfuncs.h becomes empty, so remove it too.
The prototypes it initially had were absorbed by generated fmgrprotos.h.

Discussion: https://postgr.es/m/20191115214102.GA15616@alvherre.pgsql
This commit is contained in:
Alvaro Herrera
2020-03-17 18:18:01 -03:00
parent bcd1c36300
commit 5d0c2d5eba
4 changed files with 5 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/replication/logical/logicalfuncs.c
View File

@ -28,7 +28,6 @@
#include "nodes/makefuncs.h"
#include "replication/decode.h"
#include "replication/logical.h"
#include "replication/logicalfuncs.h"
#include "replication/message.h"
#include "storage/fd.h"
#include "utils/array.h"
@ -105,14 +104,6 @@ check_permissions(void)
errmsg("must be superuser or replication role to use replication slots")));
}
int
logical_read_local_xlog_page(XLogReaderState *state, XLogRecPtr targetPagePtr,
int reqLen, XLogRecPtr targetRecPtr, char *cur_page)
{
return read_local_xlog_page(state, targetPagePtr, reqLen,
targetRecPtr, cur_page);
}
/*
* Helper function for the various SQL callable logical decoding functions.
*/
@ -242,7 +233,7 @@ pg_logical_slot_get_changes_guts(FunctionCallInfo fcinfo, bool confirm, bool bin
ctx = CreateDecodingContext(InvalidXLogRecPtr,
options,
false,
logical_read_local_xlog_page,
read_local_xlog_page,
LogicalOutputPrepareWrite,
LogicalOutputWrite, NULL);