database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Fix another couple of outdated comments for MERGE RETURNING.

Browse Source 
Oversights in c649fa24a4 which added RETURNING support to MERGE.

Discussion: https://postgr.es/m/CAApHDvpqp6vtUzG-_josUEiBGyqnrnVxJ-VdF+hJLXjHdHzsyQ@mail.gmail.com
This commit is contained in:
Dean Rasheed
2024-06-04 09:29:42 +01:00
parent 83fc61ccfa
commit 5c5bccef21
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/utils/adt/ruleutils.c
View File

@@ -6016,7 +6016,7 @@ get_basic_select_query(Query *query, deparse_context *context,
/* ---------- /* ----------
* get_target_list - Parse back a SELECT target list * get_target_list - Parse back a SELECT target list
* *
* This is also used for RETURNING lists in INSERT/UPDATE/DELETE. * This is also used for RETURNING lists in INSERT/UPDATE/DELETE/MERGE.
* *
* resultDesc and colNamesVisible are as for get_query_def() * resultDesc and colNamesVisible are as for get_query_def()
* ---------- * ----------

2
src/include/nodes/parsenodes.h
View File

@@ -154,7 +154,7 @@ typedef struct Query
bool hasDistinctOn pg_node_attr(query_jumble_ignore); bool hasDistinctOn pg_node_attr(query_jumble_ignore);
/* WITH RECURSIVE was specified */ /* WITH RECURSIVE was specified */
bool hasRecursive pg_node_attr(query_jumble_ignore); bool hasRecursive pg_node_attr(query_jumble_ignore);
/* has INSERT/UPDATE/DELETE in WITH */ /* has INSERT/UPDATE/DELETE/MERGE in WITH */
bool hasModifyingCTE pg_node_attr(query_jumble_ignore); bool hasModifyingCTE pg_node_attr(query_jumble_ignore);
/* FOR [KEY] UPDATE/SHARE was specified */ /* FOR [KEY] UPDATE/SHARE was specified */
bool hasForUpdate pg_node_attr(query_jumble_ignore); bool hasForUpdate pg_node_attr(query_jumble_ignore);

6
src/include/utils/portal.h
View File

@@ -64,9 +64,9 @@
* supports holdable cursors (the Executor results can be dumped into a * supports holdable cursors (the Executor results can be dumped into a
* tuplestore for access after transaction completion). * tuplestore for access after transaction completion).
* *
* PORTAL_ONE_RETURNING: the portal contains a single INSERT/UPDATE/DELETE * PORTAL_ONE_RETURNING: the portal contains a single INSERT/UPDATE/DELETE/
* query with a RETURNING clause (plus possibly auxiliary queries added by * MERGE query with a RETURNING clause (plus possibly auxiliary queries added
* rule rewriting). On first execution, we run the portal to completion * by rule rewriting). On first execution, we run the portal to completion
* and dump the primary query's results into the portal tuplestore; the * and dump the primary query's results into the portal tuplestore; the
* results are then returned to the client as demanded. (We can't support * results are then returned to the client as demanded. (We can't support
* suspension of the query partway through, because the AFTER TRIGGER code * suspension of the query partway through, because the AFTER TRIGGER code