From 5c05d165afe108e70a63d65a31964072f4396c23 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 12 Oct 2005 17:18:31 +0000 Subject: [PATCH] Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark the wrong buffer dirty when trying to kill a dead index entry that's on a page after the one it started on. No risk of data corruption, just inefficiency, but still a bug. --- src/backend/access/nbtree/nbtinsert.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c index d2644b25dde..299425a1e55 100644 --- a/src/backend/access/nbtree/nbtinsert.c +++ b/src/backend/access/nbtree/nbtinsert.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.106.2.1 2004/08/17 23:16:07 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.106.2.2 2005/10/12 17:18:31 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -270,7 +270,10 @@ _bt_check_unique(Relation rel, BTItem btitem, Relation heapRel, HEAPTUPLE_DEAD) { curitemid->lp_flags |= LP_DELETE; - SetBufferCommitInfoNeedsSave(buf); + if (nbuf != InvalidBuffer) + SetBufferCommitInfoNeedsSave(nbuf); + else + SetBufferCommitInfoNeedsSave(buf); } if (sv_infomask != htup.t_data->t_infomask) SetBufferCommitInfoNeedsSave(hbuffer);