database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Skip not SOAP-supported indexes while transforming an OR clause into SAOP

Browse Source 
There is no point in transforming OR-clauses into SAOP's if the target index
doesn't support SAOP scans anyway.  This commit adds corresponding checks
to match_orclause_to_indexcol() and group_similar_or_args().  The first check
fixes the actual bug, while the second just saves some cycles.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/8174de69-9e1a-0827-0e81-ef97f56a5939%40gmail.com
Author: Alena Rybakina
Reviewed-by: Ranier Vilela, Alexander Korotkov, Andrei Lepikhov
This commit is contained in:
Alexander Korotkov
2024-11-29 09:48:29 +02:00
parent b6612aedc5
commit 5bba0546ee
3 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/optimizer/path/indxpath.c
View File

@ -1354,8 +1354,11 @@ group_similar_or_args(PlannerInfo *root, RelOptInfo *rel, RestrictInfo *rinfo)
{
IndexOptInfo *index = (IndexOptInfo *) lfirst(lc2);
/* Ignore index if it doesn't support bitmap scans */
if (!index->amhasgetbitmap)
/*
* Ignore index if it doesn't support bitmap scans or SAOP
* clauses.
*/
if (!index->amhasgetbitmap || !index->amsearcharray)
continue;
for (colnum = 0; colnum < index->nkeycolumns; colnum++)
@ -3248,6 +3251,10 @@ match_orclause_to_indexcol(PlannerInfo *root,
Assert(IsA(orclause, BoolExpr));
Assert(orclause->boolop == OR_EXPR);
/* Ignore index if it doesn't support SAOP clauses */
if (!index->amsearcharray)
return NULL;
/*
* Try to convert a list of OR-clauses to a single SAOP expression. Each
* OR entry must be in the form: (indexkey operator constant) or (constant