Revise handling of oldstyle/newstyle functions per recent discussions

in pghackers list.  Support for oldstyle internal functions is gone
(no longer needed, since conversion is complete) and pg_language entry
'internal' now implies newstyle call convention.  pg_language entry
'newC' is gone; both old and newstyle dynamically loaded C functions
are now called language 'C'.  A newstyle function must be identified
by an associated info routine.  See src/backend/utils/fmgr/README.

contrib/spi/autoinc.c

@@ -5,6 +5,8 @@
 
 extern Datum autoinc(PG_FUNCTION_ARGS);
 
+PG_FUNCTION_INFO_V1(autoinc);
+
 Datum
 autoinc(PG_FUNCTION_ARGS)
 {

contrib/spi/autoinc.sql.in

@@ -3,4 +3,4 @@ DROP FUNCTION autoinc();
 CREATE FUNCTION autoinc() 
 	RETURNS opaque 
 	AS 'MODULE_PATHNAME'
-	LANGUAGE 'newC';
+	LANGUAGE 'C';

contrib/spi/insert_username.c

@@ -12,6 +12,8 @@
 
 extern Datum	insert_username(PG_FUNCTION_ARGS);
 
+PG_FUNCTION_INFO_V1(insert_username);
+
 Datum
 insert_username(PG_FUNCTION_ARGS)
 {

contrib/spi/insert_username.sql.in

@@ -3,4 +3,4 @@ DROP FUNCTION insert_username();
 CREATE FUNCTION insert_username() 
 	RETURNS opaque 
 	AS 'MODULE_PATHNAME'
-	LANGUAGE 'newC';
+	LANGUAGE 'C';

contrib/spi/moddatetime.c

@@ -17,6 +17,8 @@ OH, me, I'm Terry Mackintosh <terry@terrym.com>
 
 extern Datum	moddatetime(PG_FUNCTION_ARGS);
 
+PG_FUNCTION_INFO_V1(moddatetime);
+
 Datum
 moddatetime(PG_FUNCTION_ARGS)
 {

contrib/spi/moddatetime.sql.in

@@ -3,4 +3,4 @@ DROP FUNCTION moddatetime();
 CREATE FUNCTION moddatetime() 
 	RETURNS opaque 
 	AS 'MODULE_PATHNAME'
-	LANGUAGE 'newC';
+	LANGUAGE 'C';

contrib/spi/refint.c

@@ -36,6 +36,8 @@ static EPlan *find_plan(char *ident, EPlan ** eplan, int *nplans);
  * check_primary_key ('Fkey1', 'Fkey2', 'Ptable', 'Pkey1', 'Pkey2').
  */
 
+PG_FUNCTION_INFO_V1(check_primary_key);
+
 Datum
 check_primary_key(PG_FUNCTION_ARGS)
 {
@@ -216,6 +218,8 @@ check_primary_key(PG_FUNCTION_ARGS)
  * 'Ftable1', 'Fkey11', 'Fkey12', 'Ftable2', 'Fkey21', 'Fkey22').
  */
 
+PG_FUNCTION_INFO_V1(check_foreign_key);
+
 Datum
 check_foreign_key(PG_FUNCTION_ARGS)
 {

contrib/spi/refint.sql.in

@@ -4,11 +4,9 @@ DROP FUNCTION check_foreign_key ();
 CREATE FUNCTION check_primary_key ()
 	RETURNS opaque
 	AS 'MODULE_PATHNAME'
-	LANGUAGE 'newC'
-;
+	LANGUAGE 'C';
 
 CREATE FUNCTION check_foreign_key ()
 	RETURNS opaque
 	AS 'MODULE_PATHNAME'
-	LANGUAGE 'newC'
-;
+	LANGUAGE 'C';

contrib/spi/timetravel.c

@@ -47,6 +47,8 @@ static EPlan *find_plan(char *ident, EPlan ** eplan, int *nplans);
  * timetravel ('date_on', 'date_off').
  */
 
+PG_FUNCTION_INFO_V1(timetravel);
+
 Datum
 timetravel(PG_FUNCTION_ARGS)
 {
@@ -326,6 +328,8 @@ timetravel(PG_FUNCTION_ARGS)
  * set_timetravel (relname, on) --
  *					turn timetravel for specified relation ON/OFF
  */
+PG_FUNCTION_INFO_V1(set_timetravel);
+
 Datum
 set_timetravel(PG_FUNCTION_ARGS)
 {

contrib/spi/timetravel.sql.in

@@ -4,9 +4,9 @@ DROP FUNCTION set_timetravel(name, int4);
 CREATE FUNCTION timetravel() 
 	RETURNS opaque 
 	AS 'MODULE_PATHNAME'
-	LANGUAGE 'newC';
+	LANGUAGE 'C';
 
 CREATE FUNCTION set_timetravel(name, int4) 
 	RETURNS int4 
 	AS 'MODULE_PATHNAME'
-	LANGUAGE 'newC' WITH (isStrict);
+	LANGUAGE 'C' WITH (isStrict);