database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-21 15:54:08 +03:00
Code

Fix unchecked return value from strdup

Browse Source 
The pg_dump compression was using strdup() instead of pg_strdup()
and failed to check the returned pointer for out-of-memory before
dereferencing it. Fix by using pg_strdup() instead which probably
was the intention here in the original patch.

Backpatch to v16 where pg_dump compression was introduced.

Reviewed-by: Tristan Partin <tristan@neon.tech>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/CC661D60-6F4C-474D-B9CF-E789ACA3CEFC@yesql.se
Backpatch-through: 16
This commit is contained in:
Daniel Gustafsson 2023-12-20 22:37:28 +01:00
parent 94415b04ed
commit 5b5db413d2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_dump/compress_io.c
View File

@ -249,7 +249,7 @@ InitDiscoverCompressFileHandle(const char *path, const char *mode)
Assert(strcmp(mode, PG_BINARY_R) == 0); Assert(strcmp(mode, PG_BINARY_R) == 0);
fname = strdup(path); fname = pg_strdup(path);
if (hasSuffix(fname, ".gz")) if (hasSuffix(fname, ".gz"))
compression_spec.algorithm = PG_COMPRESSION_GZIP; compression_spec.algorithm = PG_COMPRESSION_GZIP;