database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-26 18:17:33 +03:00
Code

Fix file descriptor leak after failure of a \setshell command in pgbench.

Browse Source 
If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.
This commit is contained in:
Tom Lane 2014-12-16 13:31:42 -05:00
parent cd63c57e5c
commit 5b2c8f04a7
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
contrib/pgbench/pgbench.c
View File

@ -749,6 +749,7 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
{ {
if (!timer_exceeded) if (!timer_exceeded)
fprintf(stderr, "%s: cannot read the result\n", argv[0]); fprintf(stderr, "%s: cannot read the result\n", argv[0]);
(void) pclose(fp);
return false; return false;
} }
if (pclose(fp) < 0) if (pclose(fp) < 0)