database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-05 09:19:17 +03:00
Code

Teach pg_ls_dir_files() to ignore ENOENT failures from stat().

Browse Source 
Buildfarm experience shows that this function can fail with ENOENT
if some other process unlinks a file between when we read the directory
entry and when we try to stat() it.  The problem is old but we had
not noticed it until 085b6b667 added regression test coverage.

To fix, just ignore ENOENT failures.  There is one other case that
this might hide: a symlink that points to nowhere.  That seems okay
though, at least better than erroring.

Back-patch to v10 where this function was added, since the regression
test cases were too.

Discussion: https://postgr.es/m/20200308173103.GC1357@telsasoft.com
This commit is contained in:
Tom Lane 2020-03-31 12:57:55 -04:00
parent fade4d4dff
commit 5b22ff764b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/utils/adt/genfile.c
View File

@ -581,9 +581,14 @@ pg_ls_dir_files(FunctionCallInfo fcinfo, const char *dir)
/* Get the file info */ /* Get the file info */
snprintf(path, sizeof(path), "%s/%s", dir, de->d_name); snprintf(path, sizeof(path), "%s/%s", dir, de->d_name);
if (stat(path, &attrib) < 0) if (stat(path, &attrib) < 0)
{
/* Ignore concurrently-deleted files, else complain */
if (errno == ENOENT)
continue;
ereport(ERROR, ereport(ERROR,
(errcode_for_file_access(), (errcode_for_file_access(),
errmsg("could not stat file \"%s\": %m", path))); errmsg("could not stat file \"%s\": %m", path)));
}
/* Ignore anything but regular files */ /* Ignore anything but regular files */
if (!S_ISREG(attrib.st_mode)) if (!S_ISREG(attrib.st_mode))