database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-19 17:02:53 +03:00
Code Activity

Fix allocation formula in llvmjit_expr.c

Browse Source 
An array of LLVMBasicBlockRef is allocated with the size used for an
element being "LLVMBasicBlockRef *" rather than "LLVMBasicBlockRef".
LLVMBasicBlockRef is a type that refers to a pointer, so this did not
directly cause a problem because both should have the same size, still
it is incorrect.

This issue has been spotted while reviewing a different patch, and
exists since 2a0faed9d7, so backpatch all the way down.

Discussion: https://postgr.es/m/CA+hUKGLngd9cKHtTUuUdEo2eWEgUcZ_EQRbP55MigV2t_zTReg@mail.gmail.com
Backpatch-through: 14
This commit is contained in:
Michael Paquier
2025-12-11 10:25:48 +09:00
parent d62a258cd4
commit 5a4dc4aabd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/jit/llvm/llvmjit_expr.c
View File

@@ -612,8 +612,8 @@ llvm_compile_expr(ExprState *state)
LLVMBuildStore(b, l_sbool_const(1), v_resnullp); LLVMBuildStore(b, l_sbool_const(1), v_resnullp);
/* create blocks for checking args, one for each */ /* create blocks for checking args, one for each */
b_checkargnulls = b_checkargnulls = (LLVMBasicBlockRef *)
palloc(sizeof(LLVMBasicBlockRef *) * op->d.func.nargs); palloc(sizeof(LLVMBasicBlockRef) * op->d.func.nargs);
for (int argno = 0; argno < op->d.func.nargs; argno++) for (int argno = 0; argno < op->d.func.nargs; argno++)
b_checkargnulls[argno] = b_checkargnulls[argno] =
l_bb_before_v(b_nonull, "b.%d.isnull.%d", opno, l_bb_before_v(b_nonull, "b.%d.isnull.%d", opno,