database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-13 14:22:43 +03:00
Code Activity

Remove read_file/write_file tests. These were originally intended to

Browse Source 
*fail*, to test that plpython didn't allow untrusted operations.
When we changed plpython to plpythonu because python didn't actually have
a secure sandbox mode, someone (probably me :-() misinterpreted the tests
as checking whether Python's file I/O works.  Which is a stupid thing for
us to be testing.  Remove it so we don't clutter the filesystem with
random temporary files.
This commit is contained in:
Tom Lane
2005-06-20 21:14:01 +00:00
parent 9d7c005243
commit 59ee9448a8
4 changed files with 0 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/pl/plpython/sql/plpython_error.sql
View File

@@ -7,7 +7,3 @@ SELECT invalid_type_uncaught('rick');
SELECT invalid_type_caught('rick');
SELECT invalid_type_reraised('rick');
SELECT valid_type('rick');
-- Security sandbox tests
SELECT write_file('/tmp/plpython','Only trusted users should be able to do this!');
SELECT read_file('/tmp/plpython');

9
src/pl/plpython/sql/plpython_function.sql
View File

@@ -298,15 +298,6 @@ return seq
'
LANGUAGE plpythonu;
CREATE OR REPLACE FUNCTION read_file(text) RETURNS text AS '
return open(args[0]).read()
' LANGUAGE plpythonu;
CREATE OR REPLACE FUNCTION write_file(text,text) RETURNS text AS '
open(args[0],"w").write(args[1])
return "Wrote to file: %s" % args[0]
' LANGUAGE plpythonu;
--
-- Universal Newline Support
--