database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-16 06:01:02 +03:00
Code Activity

Remove empty function BufmgrCommit().

Browse Source 
This function has been a no-op for over a decade.  Even if bufmgr
regains a need to be called during commit, it seems unlikely that
the most appropriate call points would be precisely here, so it's not
doing us much good as a placeholder either.  Now, removing it probably
doesn't save any noticeable number of cycles --- but the main call is
inside the commit critical section, and the less work done there the
better.

Matthias van de Meent

Discussion: https://postgr.es/m/CAEze2Wi1=tLKbxZnXzcD+8fYKyKqBtivVakLQC_mYBsP4Y8qVA@mail.gmail.com
This commit is contained in:
Tom Lane
2023-03-29 09:13:57 -04:00
parent 7081ac46ac
commit 58c9600a9f
3 changed files with 3 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/storage/buffer/bufmgr.c
View File

@ -2789,16 +2789,6 @@ CheckPointBuffers(int flags)
BufferSync(flags);
}
/*
* Do whatever is needed to prepare for commit at the bufmgr and smgr levels
*/
void
BufmgrCommit(void)
{
/* Nothing to do in bufmgr anymore... */
}
/*
* BufferGetBlockNumber
* Returns the block number associated with a buffer.