database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-26 01:22:12 +03:00
Code Activity

aio: Avoid spurious coverity warning

Browse Source 
PgAioResult.result is never accessed in the relevant path, but coverity
complains about an uninitialized access anyway. So just zero-initialize the
whole thing.  While at it, reduce the scope of the variable.

Reported-by: Ranier Vilela <ranier.vf@gmail.com>
Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/CAEudQApsKqd-s+fsUQ0OmxJAMHmBSXxrAz3dCs+uvqb3iRtjSw@mail.gmail.com
This commit is contained in:
Andres Freund
2025-04-04 15:15:39 -04:00
parent 8ab6ef2bb8
commit 57dec20fd4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/storage/buffer/bufmgr.c
View File

@ -6868,8 +6868,6 @@ buffer_readv_complete_one(PgAioTargetData *td, uint8 buf_off, Buffer buffer,
/* Check for garbage data. */ /* Check for garbage data. */
if (!failed) if (!failed)
{ {
PgAioResult result_one;
if (!PageIsVerified((Page) bufdata, tag.blockNum, piv_flags, if (!PageIsVerified((Page) bufdata, tag.blockNum, piv_flags,
failed_checksum)) failed_checksum))
{ {
@ -6904,6 +6902,8 @@ buffer_readv_complete_one(PgAioTargetData *td, uint8 buf_off, Buffer buffer,
*/ */
if (*buffer_invalid || *failed_checksum || *zeroed_buffer) if (*buffer_invalid || *failed_checksum || *zeroed_buffer)
{ {
PgAioResult result_one = {0};
buffer_readv_encode_error(&result_one, is_temp, buffer_readv_encode_error(&result_one, is_temp,
*zeroed_buffer, *zeroed_buffer,
*ignored_checksum, *ignored_checksum,