database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

gistendscan() forgot to free so->giststate.

Browse Source 
This oversight led to a massive memory leak --- upwards of 10KB per tuple
--- during creation-time verification of an exclusion constraint based on a
GIST index.  In most other scenarios it'd just be a leak of 10KB that would
be recovered at end of query, so not too significant; though perhaps the
leak would be noticeable in a situation where a GIST index was being used
in a nestloop inner indexscan.  In any case, it's a real leak of long
standing, so patch all supported branches.  Per report from Harald Fuchs.
This commit is contained in:
Tom Lane
2011-09-16 04:27:56 -04:00
parent f6950429da
commit 57d3dc2035
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/access/gist/gistscan.c
View File

@@ -242,6 +242,7 @@ gistendscan(PG_FUNCTION_ARGS)
GISTScanOpaque so = (GISTScanOpaque) scan->opaque; GISTScanOpaque so = (GISTScanOpaque) scan->opaque;
freeGISTstate(so->giststate); freeGISTstate(so->giststate);
pfree(so->giststate);
MemoryContextDelete(so->queueCxt); MemoryContextDelete(so->queueCxt);
MemoryContextDelete(so->tempCxt); MemoryContextDelete(so->tempCxt);
pfree(so->tmpTreeItem); pfree(so->tmpTreeItem);