database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-09 13:09:39 +03:00
Code Activity

_SPI_cursor_operation forgot to check for failure return from

Browse Source 
_SPI_begin_call.  Per gripe from Tomasz Myrta.
This commit is contained in:
Tom Lane
2003-09-23 15:11:41 +00:00
parent 5f2b17e617
commit 57040f5069
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/executor/spi.c
View File

@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.75.2.3 2003/02/14 21:12:54 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.75.2.4 2003/09/23 15:11:41 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -1387,7 +1387,8 @@ _SPI_cursor_operation(Portal portal, bool forward, int count,
elog(ERROR, "invalid portal in SPI cursor operation");
/* Push the SPI stack */
_SPI_begin_call(true);
if (_SPI_begin_call(true) < 0)
elog(ERROR, "SPI cursor operation called while not connected");
/* Reset the SPI result */
SPI_processed = 0;
@@ -1468,8 +1469,7 @@ _SPI_procmem()
}
/*
* _SPI_begin_call
*
* _SPI_begin_call: begin a SPI operation within a connected procedure
*/
static int
_SPI_begin_call(bool execmem)
@@ -1486,6 +1486,11 @@ _SPI_begin_call(bool execmem)
return 0;
}
/*
* _SPI_end_call: end a SPI operation within a connected procedure
*
* Note: this currently has no failure return cases, so callers don't check
*/
static int
_SPI_end_call(bool procmem)
{