mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
Block replication slot advance for these not yet reserving WAL
Such replication slots are physical slots freshly created without WAL being reserved, which is the default behavior, which have not been used yet as WAL consumption resources to retain WAL. This prevents advancing a slot to a position older than any WAL available, which could falsify calculations for WAL segment recycling. This also cleans up a bit the code, as ReplicationSlotRelease() would be called on ERROR, and improves error messages. Reported-by: Kyotaro Horiguchi Author: Michael Paquier Reviewed-by: Andres Freund, Álvaro Herrera, Kyotaro Horiguchi Discussion: https://postgr.es/m/20180626071305.GH31353@paquier.xyz
This commit is contained in:
@ -131,3 +131,20 @@ SELECT pg_drop_replication_slot('regression_slot1');
|
||||
ERROR: replication slot "regression_slot1" does not exist
|
||||
SELECT pg_drop_replication_slot('regression_slot2');
|
||||
ERROR: replication slot "regression_slot2" does not exist
|
||||
-- slot advance with physical slot, error with non-reserved slot
|
||||
SELECT slot_name FROM pg_create_physical_replication_slot('regression_slot3');
|
||||
slot_name
|
||||
------------------
|
||||
regression_slot3
|
||||
(1 row)
|
||||
|
||||
SELECT pg_replication_slot_advance('regression_slot3', '0/0'); -- invalid LSN
|
||||
ERROR: invalid target wal lsn
|
||||
SELECT pg_replication_slot_advance('regression_slot3', '0/1'); -- error
|
||||
ERROR: cannot advance replication slot that has not previously reserved WAL
|
||||
SELECT pg_drop_replication_slot('regression_slot3');
|
||||
pg_drop_replication_slot
|
||||
--------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
|
Reference in New Issue
Block a user