mirror of
https://github.com/postgres/postgres.git
synced 2025-09-02 04:21:28 +03:00
Prevent concurrent SimpleLruTruncate() for any given SLRU.
The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access status of transaction" errors. Data loss is more likely in pg_multixact, due to released branches' thin margin between multiStopLimit and multiWrapLimit. If a user's physical replication primary logged ": apparent wraparound" messages, the user should rebuild standbys of that primary regardless of symptoms. At less risk is a cluster having emitted "not accepting commands" errors or "must be vacuumed" warnings at some point. One can test a cluster for this data loss by running VACUUM FREEZE in every database. Back-patch to 9.5 (all supported versions). Discussion: https://postgr.es/m/20190218073103.GA1434723@rfd.leadboat.com
This commit is contained in:
@@ -460,6 +460,21 @@ UnlockRelationForExtension(Relation relation, LOCKMODE lockmode)
|
||||
LockRelease(&tag, lockmode, false);
|
||||
}
|
||||
|
||||
/*
|
||||
* LockDatabaseFrozenIds
|
||||
*
|
||||
* This allows one backend per database to execute vac_update_datfrozenxid().
|
||||
*/
|
||||
void
|
||||
LockDatabaseFrozenIds(LOCKMODE lockmode)
|
||||
{
|
||||
LOCKTAG tag;
|
||||
|
||||
SET_LOCKTAG_DATABASE_FROZEN_IDS(tag, MyDatabaseId);
|
||||
|
||||
(void) LockAcquire(&tag, lockmode, false, false);
|
||||
}
|
||||
|
||||
/*
|
||||
* LockPage
|
||||
*
|
||||
@@ -1098,6 +1113,11 @@ DescribeLockTag(StringInfo buf, const LOCKTAG *tag)
|
||||
tag->locktag_field2,
|
||||
tag->locktag_field1);
|
||||
break;
|
||||
case LOCKTAG_DATABASE_FROZEN_IDS:
|
||||
appendStringInfo(buf,
|
||||
_("pg_database.datfrozenxid of database %u"),
|
||||
tag->locktag_field1);
|
||||
break;
|
||||
case LOCKTAG_PAGE:
|
||||
appendStringInfo(buf,
|
||||
_("page %u of relation %u of database %u"),
|
||||
|
@@ -50,3 +50,6 @@ MultiXactTruncationLock 41
|
||||
OldSnapshotTimeMapLock 42
|
||||
LogicalRepWorkerLock 43
|
||||
XactTruncationLock 44
|
||||
# 45 was XactTruncationLock until removal of BackendRandomLock
|
||||
WrapLimitsVacuumLock 46
|
||||
NotifyQueueTailLock 47
|
||||
|
Reference in New Issue
Block a user