database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-25 01:39:28 +03:00
Code Activity

Avoid SIGSEGV in pg_get_database_ddl() on NULL tablespace

Browse Source 
There is a narrow race in which a concurrent ALTER DATABASE ... SET
TABLESPACE moves the database off the tablespace and a DROP TABLESPACE
removes it between the syscache lookup and the catalog scan. If that
happens, output an error.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Jack Bonatakis <jack@bonatak.is>
Reviewed-by: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/573E45C1-31A4-4885-A00C-1A2171159A2A@gmail.com
This commit is contained in:
Andrew Dunstan
2026-04-30 10:14:52 -04:00
parent 75152c5dc5
commit 5642a0367c
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/utils/adt/ddlutils.c
View File

@@ -986,6 +986,13 @@ pg_get_database_ddl_internal(Oid dbid, bool pretty,
{
char *spcname = get_tablespace_name(dbform->dattablespace);
if (spcname == NULL)
ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_OBJECT),
errmsg("tablespace with OID %u does not exist",
dbform->dattablespace),
errdetail("It may have been concurrently dropped.")));
if (pg_strcasecmp(spcname, "pg_default") != 0)
append_ddl_option(&buf, pretty, 4, "TABLESPACE = %s",
quote_identifier(spcname));