database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

Code review for array_fill patch: fix inadequate check for array size overflow

Browse Source 
and bogus documentation (dimension arrays are int[] not anyarray).  Also the
errhint() messages seem to be really errdetail(), since there is nothing
heuristic about them.  Some other trivial cosmetic improvements.
This commit is contained in:
Tom Lane
2008-07-21 04:47:00 +00:00
parent 673a30fbb2
commit 5618ece82b
3 changed files with 66 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
doc/src/sgml/func.sgml
View File

@ -1,4 +1,4 @@
<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.442 2008/07/18 03:32:51 tgl Exp $ -->
<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.443 2008/07/21 04:47:00 tgl Exp $ -->
<chapter id="functions">
<title>Functions and Operators</title>
@ -9186,17 +9186,16 @@ SELECT NULLIF(value, '(none)') ...
</sect2>
</sect1>
<sect1 id="functions-array">
<title>Array Functions and Operators</title>
<para>
<xref linkend="array-operators-table"> shows the operators
available for <type>array</type> types.
available for array types.
</para>
<table id="array-operators-table">
<title><type>array</type> Operators</title>
<title>Array Operators</title>
<tgroup cols="4">
<thead>
<row>
@ -9326,7 +9325,7 @@ SELECT NULLIF(value, '(none)') ...
</para>
<table id="array-functions-table">
<title><type>array</type> Functions</title>
<title>Array Functions</title>
<tgroup cols="5">
<thead>
<row>
@ -9374,13 +9373,13 @@ SELECT NULLIF(value, '(none)') ...
<row>
<entry>
<literal>
<function>array_fill</function>(<type>anyelement</type>, <type>anyarray</type>,
<optional>, <type>anyarray</type></optional>)
<function>array_fill</function>(<type>anyelement</type>, <type>int[]</type>,
<optional>, <type>int[]</type></optional>)
</literal>
</entry>
<entry><type>anyarray</type></entry>
<entry>returns an array initialized with supplied value,
dimensions, and lower bounds</entry>
<entry>returns an array initialized with supplied value and
dimensions, optionally with lower bounds other than 1</entry>
<entry><literal>array_fill(7, ARRAY[3], ARRAY[2])</literal></entry>
<entry><literal>[2:4]={7,7,7}</literal></entry>
</row>