database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-20 00:42:27 +03:00
Code

Avoid misbehavior when hash_table_bytes < bucket_size.

Browse Source 
It's possible to reach this case when work_mem is very small and tupsize
is (relatively) very large.  In that case ExecChooseHashTableSize would
get an assertion failure, or with asserts off it'd compute nbuckets = 0,
which'd likely cause misbehavior later (I've not checked).  To fix,
clamp the number of buckets to be at least 1.

This is due to faulty conversion of old my_log2() coding in 28d936031.
Back-patch to v13, as that was.

Zhang Mingli

Discussion: https://postgr.es/m/beb64ca0-91e2-44ac-bf4a-7ea36275ec02@Spark
This commit is contained in:
Tom Lane 2022-08-13 16:59:58 -04:00
parent f558088285
commit 55d9cd46f6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/executor/nodeHash.c
View File

@ -832,7 +832,10 @@ ExecChooseHashTableSize(double ntuples, int tupwidth, bool useskew,
* overhead for the hash code, pointer to the next tuple, etc. * overhead for the hash code, pointer to the next tuple, etc.
*/ */
bucket_size = (tupsize * NTUP_PER_BUCKET + sizeof(HashJoinTuple)); bucket_size = (tupsize * NTUP_PER_BUCKET + sizeof(HashJoinTuple));
sbuckets = pg_nextpower2_size_t(hash_table_bytes / bucket_size); if (hash_table_bytes <= bucket_size)
sbuckets = 1; /* avoid pg_nextpower2_size_t(0) */
else
sbuckets = pg_nextpower2_size_t(hash_table_bytes / bucket_size);
sbuckets = Min(sbuckets, max_pointers); sbuckets = Min(sbuckets, max_pointers);
nbuckets = (int) sbuckets; nbuckets = (int) sbuckets;
nbuckets = pg_nextpower2_32(nbuckets); nbuckets = pg_nextpower2_32(nbuckets);