From 55b8ac81723c45dca95d4ad4892a1ee28db37c23 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 6 Jul 2022 17:26:27 -0400 Subject: [PATCH] Fix wrong field order in _readMergeWhenClause(). We hadn't noticed this because it's dead code: there is no situation where we read raw parse trees from text format. So maybe the right fix is to remove the function altogether, but I'll forbear for now; it's not the only dead code in readfuncs.c, I think. Noted while comparing existing code to the results of Peter's auto-generation script. --- src/backend/nodes/readfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/nodes/readfuncs.c b/src/backend/nodes/readfuncs.c index 6a05b694152..014b3005af8 100644 --- a/src/backend/nodes/readfuncs.c +++ b/src/backend/nodes/readfuncs.c @@ -485,10 +485,10 @@ _readMergeWhenClause(void) READ_BOOL_FIELD(matched); READ_ENUM_FIELD(commandType, CmdType); + READ_ENUM_FIELD(override, OverridingKind); READ_NODE_FIELD(condition); READ_NODE_FIELD(targetList); READ_NODE_FIELD(values); - READ_ENUM_FIELD(override, OverridingKind); READ_DONE(); }