database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

Fix a dozen or so places that were passing unpredictable data strings

Browse Source 
as elog format strings.  Hai-Chen Tu pointed out the problem in
contrib/dbmirror, but it wasn't the only such error.
This commit is contained in:
Tom Lane
2002-11-22 16:25:55 +00:00
parent 7082e7e43a
commit 55994bab8e
6 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/cube/cubeparse.y
View File

@ -200,7 +200,7 @@ int cube_yyerror ( char *msg ) {
);
reset_parse_buffer();
elog(ERROR, buf);
elog(ERROR, "%s", buf);
return 0;
}

14
contrib/dbmirror/pending.c
View File

@ -1,6 +1,6 @@
/****************************************************************************
* pending.c
* $Id: pending.c,v 1.6.2.2 2002/11/22 16:05:06 momjian Exp $
* $Id: pending.c,v 1.6.2.3 2002/11/22 16:25:52 tgl Exp $
*
* This file contains a trigger for Postgresql-7.x to record changes to tables
* to a pending table for mirroring.
@ -253,7 +253,7 @@ storeKeyInfo(char *cpTableName, HeapTuple tTupleData,
return -1;
}
#if defined DEBUG_OUTPUT
elog(NOTICE, "%s", cpKeyData);
elog(NOTICE, "KeyData: %s", cpKeyData);
#endif
saPlanData[0] = PointerGetDatum(cpKeyData);
@ -268,7 +268,7 @@ storeKeyInfo(char *cpTableName, HeapTuple tTupleData,
return -1;
}
#if defined DEBUG_OUTPUT
elog(NOTICE, "INSERT SUCCESFULL");
elog(NOTICE, "Insert successful");
#endif
return 0;
@ -351,7 +351,7 @@ storeData(char *cpTableName, HeapTuple tTupleData, TupleDesc tTupleDesc,
return -1;
}
#if defined DEBUG_OUTPUT
elog(NOTICE, "INSERT SUCCESFULL");
elog(NOTICE, "Insert successful");
#endif
return 0;
@ -437,7 +437,7 @@ packageData(HeapTuple tTupleData, TupleDesc tTupleDesc,
cpFieldName = DatumGetPointer(NameGetDatum(&tTupleDesc->attrs
[iColumnCounter - 1]->attname));
#if defined DEBUG_OUTPUT
elog(NOTICE, "%s", cpFieldName);
elog(NOTICE, "FieldName: %s", cpFieldName);
#endif
while (iDataBlockSize - iUsedDataBlock < strlen(cpFieldName) + 6)
{
@ -465,7 +465,7 @@ packageData(HeapTuple tTupleData, TupleDesc tTupleDesc,
}
#if defined DEBUG_OUTPUT
elog(NOTICE, "%s", cpFieldData);
elog(NOTICE, "FieldData: %s", cpFieldData);
elog(NOTICE, "Starting format loop");
#endif
while (*cpUnFormatedPtr != 0)
@ -499,7 +499,7 @@ packageData(HeapTuple tTupleData, TupleDesc tTupleDesc,
sprintf(cpFormatedPtr, "' ");
iUsedDataBlock = iUsedDataBlock + 2;
#if defined DEBUG_OUTPUT
elog(NOTICE, "%s", cpDataBlock);
elog(NOTICE, "DataBlock: %s", cpDataBlock);
#endif
} /* for iColumnCounter */

6
contrib/rserv/rserv.c
View File

@ -132,7 +132,7 @@ _rserv_log_()
GetCurrentTransactionId(), deleted, rel->rd_id, okey);
if (debug)
elog(DEBUG3, sql);
elog(DEBUG3, "sql: %s", sql);
ret = SPI_exec(sql, 0);
@ -153,7 +153,7 @@ _rserv_log_()
deleted, okey);
if (debug)
elog(DEBUG3, sql);
elog(DEBUG3, "sql: %s", sql);
ret = SPI_exec(sql, 0);
@ -177,7 +177,7 @@ _rserv_log_()
rel->rd_id, GetCurrentTransactionId(), okey);
if (debug)
elog(DEBUG3, sql);
elog(DEBUG3, "sql: %s", sql);
ret = SPI_exec(sql, 0);

4
contrib/seg/segparse.y
View File

@ -144,7 +144,7 @@ float seg_atof ( char *value ) {
if ( errno ) {
snprintf(buf, 256, "numeric value %s unrepresentable", value);
reset_parse_buffer();
elog(ERROR, buf);
elog(ERROR, "%s", buf);
}
return result;
@ -175,7 +175,7 @@ int seg_yyerror ( char *msg ) {
);
reset_parse_buffer();
elog(ERROR, buf);
elog(ERROR, "%s", buf);
return 0;
}