database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-16 06:01:02 +03:00
Code Activity

copy_relation_data was mistakenly assuming that the source relation

Browse Source 
would always be already open at the smgr level.  Per bug report from
Fabien Coelho.
This commit is contained in:
Tom Lane
2004-08-31 15:56:39 +00:00
parent b4456e6d6a
commit 556110f4e0
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/commands/tablecmds.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.129 2004/08/29 05:06:41 momjian Exp $ * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.130 2004/08/31 15:56:39 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -5434,7 +5434,7 @@ ATExecSetTableSpace(Oid tableOid, Oid newTableSpace)
static void static void
copy_relation_data(Relation rel, SMgrRelation dst) copy_relation_data(Relation rel, SMgrRelation dst)
{ {
SMgrRelation src = rel->rd_smgr; SMgrRelation src;
bool use_wal; bool use_wal;
BlockNumber nblocks; BlockNumber nblocks;
BlockNumber blkno; BlockNumber blkno;
@ -5457,6 +5457,9 @@ copy_relation_data(Relation rel, SMgrRelation dst)
use_wal = XLogArchivingActive() && !rel->rd_istemp; use_wal = XLogArchivingActive() && !rel->rd_istemp;
nblocks = RelationGetNumberOfBlocks(rel); nblocks = RelationGetNumberOfBlocks(rel);
/* RelationGetNumberOfBlocks will certainly have opened rd_smgr */
src = rel->rd_smgr;
for (blkno = 0; blkno < nblocks; blkno++) for (blkno = 0; blkno < nblocks; blkno++)
{ {
smgrread(src, blkno, buf); smgrread(src, blkno, buf);