1
0
mirror of https://github.com/postgres/postgres.git synced 2025-07-02 09:02:37 +03:00

Fix failure to create FKs correctly in partitions

On a multi-level partioned table, when adding a partition not directly
connected to the root table, foreign key constraints referencing the
root were not cloned to the new partition, leading to the FK being
possibly inadvertently violated later on.

This was caused by fuzzy thinking in CloneFkReferenced (commit
f56f8f8da6): it was skipping constraints marked as having parents on
the theory that cloning those would create duplicates; but that's only
correct for the top level of the partitioning hierarchy.  For levels
below that one, such constraints must still be considered and only
skipped if later on we see that we'd create duplicates.  Apparently, I
(Álvaro) wrote the comments right but the code implemented something
slightly different.

Author: Jehan-Guillaume de Rorthais
Discussion: https://postgr.es/m/20200206004948.238352db@firost
This commit is contained in:
Alvaro Herrera
2020-02-07 18:27:18 -03:00
parent 9710d3d4a8
commit 55173d2e66
3 changed files with 59 additions and 11 deletions

View File

@ -8962,13 +8962,13 @@ CloneFkReferenced(Relation parentRel, Relation partitionRel)
List *clone = NIL;
/*
* Search for any constraints where this partition is in the referenced
* side. However, we must ignore any constraint whose parent constraint
* is also going to be cloned, to avoid duplicates. So do it in two
* steps: first construct the list of constraints to clone, then go over
* that list cloning those whose parents are not in the list. (We must
* not rely on the parent being seen first, since the catalog scan could
* return children first.)
* Search for any constraints where this partition's parent is in the
* referenced side. However, we must not clone any constraint whose
* parent constraint is also going to be cloned, to avoid duplicates. So
* do it in two steps: first construct the list of constraints to clone,
* then go over that list cloning those whose parents are not in the list.
* (We must not rely on the parent being seen first, since the catalog
* scan could return children first.)
*/
pg_constraint = table_open(ConstraintRelationId, RowShareLock);
ScanKeyInit(&key[0],
@ -8984,10 +8984,6 @@ CloneFkReferenced(Relation parentRel, Relation partitionRel)
{
Form_pg_constraint constrForm = (Form_pg_constraint) GETSTRUCT(tuple);
/* Only try to clone the top-level constraint; skip child ones. */
if (constrForm->conparentid != InvalidOid)
continue;
clone = lappend_oid(clone, constrForm->oid);
}
systable_endscan(scan);
@ -9016,6 +9012,16 @@ CloneFkReferenced(Relation parentRel, Relation partitionRel)
elog(ERROR, "cache lookup failed for constraint %u", constrOid);
constrForm = (Form_pg_constraint) GETSTRUCT(tuple);
/*
* As explained above: don't try to clone a constraint for which we're
* going to clone the parent.
*/
if (list_member_oid(clone, constrForm->conparentid))
{
ReleaseSysCache(tuple);
continue;
}
/*
* Because we're only expanding the key space at the referenced side,
* we don't need to prevent any operation in the referencing table, so