database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

pg_upgrade: fix shutdown check for standby servers

Browse Source 
Commit 244142d32a only tested for the
pg_controldata output for primary servers, but standby servers have
different "Database cluster state" output, so check for that too.

Diagnosed-by: Michael Paquier

Discussion: https://postgr.es/m/20180810164240.GM13638@paquier.xyz

Backpatch-through: 9.3
This commit is contained in:
Bruce Momjian
2018-08-14 17:19:02 -04:00
parent 69de17186a
commit 54db0e5e17
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/bin/pg_upgrade/controldata.c
View File

@@ -149,7 +149,8 @@ get_control_data(ClusterInfo *cluster, bool live_check)
/* remove leading spaces */ /* remove leading spaces */
while (*p == ' ') while (*p == ' ')
p++; p++;
if (strcmp(p, "shut down\n") != 0) if (strcmp(p, "shut down\n") != 0 &&
strcmp(p, "shut down in recovery\n") != 0)
{ {
if (cluster == &old_cluster) if (cluster == &old_cluster)
pg_fatal("The source cluster was not shut down cleanly.\n"); pg_fatal("The source cluster was not shut down cleanly.\n");