database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-30 21:42:05 +03:00
Code Activity

Improve function header comment for create_singleton_array().

Browse Source 
Mentioning the caller is neither future-proof nor an adequate substitute
for giving an API specification.  Per gripe from Neha Khatri, though
I changed the patch around some.

Discussion: https://postgr.es/m/CAFO0U+_fS5SRhzq6uPG+4fbERhoA9N2+nPrtvaC9mmeWivxbsA@mail.gmail.com
This commit is contained in:
Tom Lane
2017-05-01 15:31:41 -04:00
parent 92a43e4857
commit 54affb41e7
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/utils/adt/array_userfuncs.c
View File

@ -455,7 +455,10 @@ array_cat(PG_FUNCTION_ARGS)
/* /*
* used by text_to_array() in varlena.c * create_singleton_array - make a one-element array
*
* If desired, the caller can ask for it to be higher than one-dimensional.
* Caller's fcinfo must be passed in, as we use fn_extra for caching.
*/ */
ArrayType * ArrayType *
create_singleton_array(FunctionCallInfo fcinfo, create_singleton_array(FunctionCallInfo fcinfo,