database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

Remove misleading read stream asserts in a few users

Browse Source 
Several read stream users asserted that the read stream was exhausted
after looping on that very condition. It was pointed out in an a
review of an as-of-yet uncommitted read stream user [1] that this was
confusing and could lead the reader to think there was a possibility of
some kind of race condition. Remove these asserts.

[1] https://postgr.es/m/F9ACE8D0-B807-4A17-B6BD-87EF0717983D%40yesql.se
This commit is contained in:
Melanie Plageman
2025-04-03 18:22:37 -04:00
parent dbd437e670
commit 54a3615f15
4 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/amcheck/verify_heapam.c
View File

@ -853,8 +853,6 @@ verify_heapam(PG_FUNCTION_ARGS)
break;
}
/* Ensure that the stream is completely read */
Assert(read_stream_next_buffer(stream, NULL) == InvalidBuffer);
read_stream_end(stream);
if (vmbuffer != InvalidBuffer)