database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Temporarily(?) weaken new pg_createsubscriber test on Windows.

Browse Source 
Don't include double-quotes (") in the generated database names
on Windows.  Doing so tickles a bug in older versions of IPC::Run,
which fail to quote command line arguments correctly for that
platform.  Possibly we can revert this after updating affected
buildfarm animals.

Discussion: https://postgr.es/m/2509767.1719773880@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2024-06-30 17:33:06 -04:00
parent 35a7b288b9
commit 5450820917
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
View File

@@ -29,6 +29,10 @@ sub generate_db
} }
$dbname .= $suffix; $dbname .= $suffix;
# Old IPC::Run mis-quotes command line arguments containing '"' on Windows
$dbname =~ tr/\"//d if ($windows_os);
$node->command_ok( $node->command_ok(
[ 'createdb', $dbname ], [ 'createdb', $dbname ],
"created database with ASCII characters from $from_char to $to_char"); "created database with ASCII characters from $from_char to $to_char");