database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-15 19:21:59 +03:00
Code Activity

Okay, I have some new code in place that hopefully should work better. I

Browse Source 
couldn't produce a full patch using cvs diff -c this time since I have
created new files and anonymous cvs usage doesn't allow you to
adds. I'm supplying the modified src/interfaces/jdbc as a tarball at :
http://www.candleweb.no/~gunnar/projects/pgsql/postgres-jdbc-2000-10-05.tgz

The new files that should be added are :

? org/postgresql/PGStatement.java
? org/postgresql/ObjectPool.java
? org/postgresql/ObjectPoolFactory.java

There is now a global static pool of free byte arrays and used byte arrays
connected to a statement object. This is the role of the new PGStatement
class. Access to the global free array is synchronized, while we rely on
the PG_Stream synchronization for the used array.

My measurements show that the perfomance boost on this code is not quite as
big as my last shot, but it is still an improvement. Maybe some of the
difference is due to the new synchronization on the global array. I think I
will look into choosing between on a connection level and global level.

I have also started experimented with improving the performance of the
various conversions. The problem here is ofcourse related handle the
various encodings. One thing I found to speed up ResultSet.getInt() a lot
was to do custom conversion on the byte array into int instead of going
through the getString() to do the conversion. But I'm unsure if this is
portable, can we assume that a digit never can be represented by more than
one byte ? It works fine in my iso-latin-8859-1 environment, but what about
other environments ? Maybe we could provide different ResultSet
implementations depending on the encoding used or delegate some methods of
the result set to an "converter class".

Check the org/postgresql/jdbc2/FastResultSet.java in the tarball above to
see the modified getInt() method.

Regards,

        Gunnar
This commit is contained in:
Bruce Momjian
2000-10-08 19:37:56 +00:00
parent 52cba15789
commit 5383b5d8ed
13 changed files with 412 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/interfaces/jdbc/org/postgresql/jdbc1/Statement.java
View File

@ -6,6 +6,7 @@ package org.postgresql.jdbc1;
// org.postgresql.jdbc2 package.
import java.sql.*;
import org.postgresql.PGStatement;
import org.postgresql.util.PSQLException;
@ -22,9 +23,8 @@ import org.postgresql.util.PSQLException;
* @see java.sql.Statement
* @see ResultSet
*/
public class Statement implements java.sql.Statement
public class Statement extends PGStatement implements java.sql.Statement
{
Connection connection; // The connection who created us
java.sql.ResultSet result = null; // The current results
SQLWarning warnings = null; // The warnings chain.
int timeout = 0; // The timeout for a query (not used)
@ -38,7 +38,7 @@ public class Statement implements java.sql.Statement
*/
public Statement (Connection c)
{
connection = c;
super(c);
}
/**
@ -89,7 +89,8 @@ public class Statement implements java.sql.Statement
*/
public void close() throws SQLException
{
result = null;
super.close();
result = null;
}
/**
@ -266,7 +267,8 @@ public class Statement implements java.sql.Statement
*/
public boolean execute(String sql) throws SQLException
{
result = connection.ExecSQL(sql);
deallocate();
result = connection.ExecSQL(this, sql);
return (result != null && ((org.postgresql.ResultSet)result).reallyResultSet());
}