database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-26 12:21:12 +03:00
Code Activity

Fix race condition in subscription TAP test 021_twophase

Browse Source 
The test did not wait for all the subscriptions to have caught up when
dropping the subscription "tab_copy".  In a slow environment, it could
be possible for the replay of the COMMIT PREPARED transaction "mygid"
to not be confirmed yet, causing one prepared transaction to be left
around before moving to the next steps of the test.

One failure noticed is a transaction found in pg_prepared_xacts for the
cases where copy_data = false and two_phase = true, but there should be
none after dropping the subscription.

As an extra safety measure, a check is added before dropping the
subscription, scanning pg_prepared_xacts to make sure that no prepared
transactions are left once both subscriptions have caught up.

Issue introduced by a8fd13cab0, fixing a problem similar to
eaf5321c35.

Per buildfarm member kestrel.

Author: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/CALDaNm329QaZ+bwU--bW6GjbNSZ8-38cDE8QWofafub7NV67oA@mail.gmail.com
Backpatch-through: 15
This commit is contained in:
Michael Paquier
2025-05-26 17:28:37 +09:00
parent 3bcb554fd2
commit 52a1df85f2
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/subscription/t/021_twophase.pl
View File

@ -373,7 +373,14 @@ $result =
$node_publisher->safe_psql('postgres', "SELECT count(*) FROM tab_copy;"); $node_publisher->safe_psql('postgres', "SELECT count(*) FROM tab_copy;");
is($result, qq(6), 'publisher inserted data'); is($result, qq(6), 'publisher inserted data');
# Wait for both subscribers to catchup
$node_publisher->wait_for_catchup($appname_copy); $node_publisher->wait_for_catchup($appname_copy);
$node_publisher->wait_for_catchup($appname);
# Make sure there are no prepared transactions on the subscriber
$result = $node_subscriber->safe_psql('postgres',
"SELECT count(*) FROM pg_prepared_xacts;");
is($result, qq(0), 'should be no prepared transactions on subscriber');
$result = $result =
$node_subscriber->safe_psql('postgres', "SELECT count(*) FROM tab_copy;"); $node_subscriber->safe_psql('postgres', "SELECT count(*) FROM tab_copy;");