mirror of
https://github.com/postgres/postgres.git
synced 2025-11-04 20:11:56 +03:00
For inplace update durability, make heap_update() callers wait.
The previous commit fixed some ways of losing an inplace update. It
remained possible to lose one when a backend working toward a
heap_update() copied a tuple into memory just before inplace update of
that tuple. In catalogs eligible for inplace update, use LOCKTAG_TUPLE
to govern admission to the steps of copying an old tuple, modifying it,
and issuing heap_update(). This includes MERGE commands. To avoid
changing most of the pg_class DDL, don't require LOCKTAG_TUPLE when
holding a relation lock sufficient to exclude inplace updaters.
Back-patch to v12 (all supported versions). In v13 and v12, "UPDATE
pg_class" or "UPDATE pg_database" can still lose an inplace update. The
v14+ UPDATE fix needs commit 86dc90056d,
and it wasn't worth reimplementing that fix without such infrastructure.
Reviewed by Nitin Motiani and (in earlier versions) Heikki Linnakangas.
Discussion: https://postgr.es/m/20231027214946.79.nmisch@google.com
This commit is contained in:
@@ -582,6 +582,9 @@ typedef struct ResultRelInfo
|
||||
* one of its ancestors; see ExecCrossPartitionUpdateForeignKey().
|
||||
*/
|
||||
List *ri_ancestorResultRels;
|
||||
|
||||
/* updates do LockTuple() before oldtup read; see README.tuplock */
|
||||
bool ri_needLockTagTuple;
|
||||
} ResultRelInfo;
|
||||
|
||||
/* ----------------
|
||||
|
||||
Reference in New Issue
Block a user