database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-09 06:21:09 +03:00
Code Activity

Repair error noticed by Roberto Cornacchia: selectivity code

Browse Source 
was rejecting negative attnums as bogus, which of course they are not.
Add code to get_attdisbursion to produce a useful value for OID attribute,
since VACUUM does not store stats for system attributes.
Also, repair bug that's been in eqjoinsel for a long time: it was taking
the max of the two columns' disbursions, whereas it should use the min.
This commit is contained in:
Tom Lane
1999-09-09 02:36:04 +00:00
parent 45500964f6
commit 51db6455ea
5 changed files with 67 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/backend/optimizer/util/clauses.c
View File

@@ -7,7 +7,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.50 1999/08/26 05:09:05 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.51 1999/09/09 02:35:53 tgl Exp $
*
* HISTORY
* AUTHOR DATE MAJOR EVENT
@@ -116,7 +116,10 @@ make_opclause(Oper *op, Var *leftop, Var *rightop)
*
* Returns the left operand of a clause of the form (op expr expr)
* or (op expr)
* NB: it is assumed (for now) that all expr must be Var nodes
*
* NB: for historical reasons, the result is declared Var *, even
* though many callers can cope with results that are not Vars.
* The result really ought to be declared Expr * or Node *.
*/
Var *
get_leftop(Expr *clause)
@@ -549,8 +552,11 @@ NumRelids(Node *clause)
* if the "something" is a constant, the value of the constant
* flags indicating whether a constant was found, and on which side.
* Default values are returned if the expression is too complicated,
* specifically -1 for the relid and attno, 0 for the constant value.
* Note that InvalidAttrNumber is *not* -1, but 0.
* specifically 0 for the relid and attno, 0 for the constant value.
*
* Note that negative attno values are *not* invalid, but represent
* system attributes such as OID. It's sufficient to check for relid=0
* to determine whether the routine succeeded.
*/
void
get_relattval(Node *clause,
@@ -610,8 +616,8 @@ get_relattval(Node *clause,
{
/* Duh, it's too complicated for me... */
default_results:
*relid = -1;
*attno = -1;
*relid = 0;
*attno = 0;
*constval = 0;
*flag = 0;
return;
@@ -663,7 +669,7 @@ static int is_single_func(Node *node)
* for a joinclause.
*
* If the clause is not of the form (var op var) or if any of the vars
* refer to nested attributes, then -1's are returned.
* refer to nested attributes, then zeroes are returned.
*
*/
void
@@ -674,10 +680,10 @@ get_rels_atts(Node *clause,
AttrNumber *attno2)
{
/* set default values */
*relid1 = -1;
*attno1 = -1;
*relid2 = -1;
*attno2 = -1;
*relid1 = 0;
*attno1 = 0;
*relid2 = 0;
*attno2 = 0;
if (is_opclause(clause))
{

8
src/backend/optimizer/util/plancat.c
View File

@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/optimizer/util/plancat.c,v 1.36 1999/07/25 23:07:26 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/optimizer/util/plancat.c,v 1.37 1999/09/09 02:35:53 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -288,7 +288,7 @@ index_selectivity(Query *root,
}
/*
* restriction_selectivity in lisp system.
* restriction_selectivity
*
* NOTE: The routine is now merged with RestrictionClauseSelectivity
* as defined in plancat.c
@@ -298,7 +298,7 @@ index_selectivity(Query *root,
* operator relation, by calling the function manager.
*
* XXX The assumption in the selectivity procedures is that if the
* relation OIDs or attribute numbers are -1, then the clause
* relation OIDs or attribute numbers are 0, then the clause
* isn't of the form (op var const).
*/
Cost
@@ -337,7 +337,7 @@ restriction_selectivity(Oid functionObjectId,
* information.
*
* XXX The assumption in the selectivity procedures is that if the
* relation OIDs or attribute numbers are -1, then the clause
* relation OIDs or attribute numbers are 0, then the clause
* isn't of the form (op var var).
*/
Cost