From 51c388987734cb318c8fa875f382ca75a34d0010 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Mon, 7 Dec 2020 09:29:32 +0900 Subject: [PATCH] Fix fd leak in pg_verifybackup An error code path newly-introduced by 87ae969 forgot to close a file descriptor when verifying a file's checksum. Per report from Coverity, via Tom Lane. --- src/bin/pg_verifybackup/pg_verifybackup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c index 07320d36997..bf388de79fa 100644 --- a/src/bin/pg_verifybackup/pg_verifybackup.c +++ b/src/bin/pg_verifybackup/pg_verifybackup.c @@ -730,6 +730,7 @@ verify_file_checksum(verifier_context *context, manifest_file *m, { report_backup_error(context, "could not initialize checksum of file \"%s\"", relpath); + close(fd); return; }