database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-23 14:01:44 +03:00
Code Activity

Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.

Browse Source 
CIC and REINDEX CONCURRENTLY assume backends see their catalog changes
no later than each backend's next transaction start.  That failed to
hold when a backend absorbed a relevant invalidation in the middle of
running RelationBuildDesc() on the CIC index.  Queries that use the
resulting index can silently fail to find rows.  Fix this for future
index builds by making RelationBuildDesc() loop until it finishes
without accepting a relevant invalidation.  It may be necessary to
reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices.
Back-patch to 9.6 (all supported versions).

Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres
Freund.

Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com
This commit is contained in:
Noah Misch
2021-10-23 18:36:38 -07:00
parent e6c5f1b452
commit 5141e471b3
7 changed files with 346 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/utils/cache/inval.c vendored
View File

@ -584,7 +584,7 @@ LocalExecuteInvalidationMessage(SharedInvalidationMessage *msg)
int i;
if (msg->rc.relId == InvalidOid)
RelationCacheInvalidate();
RelationCacheInvalidate(false);
else
RelationCacheInvalidateEntry(msg->rc.relId);
@ -641,12 +641,18 @@ LocalExecuteInvalidationMessage(SharedInvalidationMessage *msg)
*/
void
InvalidateSystemCaches(void)
{
InvalidateSystemCachesExtended(false);
}
void
InvalidateSystemCachesExtended(bool debug_discard)
{
int i;
InvalidateCatalogSnapshot();
ResetCatalogCaches();
RelationCacheInvalidate(); /* gets smgr and relmap too */
RelationCacheInvalidate(debug_discard); /* gets smgr and relmap too */
for (i = 0; i < syscache_callback_count; i++)
{
@ -717,7 +723,7 @@ AcceptInvalidationMessages(void)
if (recursion_depth < 3)
{
recursion_depth++;
InvalidateSystemCaches();
InvalidateSystemCachesExtended(true);
recursion_depth--;
}
}