mirror of
https://github.com/postgres/postgres.git
synced 2025-08-22 21:53:06 +03:00
Get rid of the planner's LateralJoinInfo data structure.
I originally modeled this data structure on SpecialJoinInfo, but after
commit acfcd45cac
that looks like a pretty poor decision.
All we really need is relid sets identifying laterally-referenced rels;
and most of the time, what we want to know about includes indirect lateral
references, a case the LateralJoinInfo data was unsuited to compute with
any efficiency. The previous commit redefined RelOptInfo.lateral_relids
as the transitive closure of lateral references, so that it easily supports
checking indirect references. For the places where we really do want just
direct references, add a new RelOptInfo field direct_lateral_relids, which
is easily set up as a copy of lateral_relids before we perform the
transitive closure calculation. Then we can just drop lateral_info_list
and LateralJoinInfo and the supporting code. This makes the planner's
handling of lateral references noticeably more efficient, and shorter too.
Such a change can't be back-patched into stable branches for fear of
breaking extensions that might be looking at the planner's data structures;
but it seems not too late to push it into 9.5, so I've done so.
This commit is contained in:
@@ -2066,20 +2066,6 @@ _copySpecialJoinInfo(const SpecialJoinInfo *from)
|
||||
return newnode;
|
||||
}
|
||||
|
||||
/*
|
||||
* _copyLateralJoinInfo
|
||||
*/
|
||||
static LateralJoinInfo *
|
||||
_copyLateralJoinInfo(const LateralJoinInfo *from)
|
||||
{
|
||||
LateralJoinInfo *newnode = makeNode(LateralJoinInfo);
|
||||
|
||||
COPY_BITMAPSET_FIELD(lateral_lhs);
|
||||
COPY_BITMAPSET_FIELD(lateral_rhs);
|
||||
|
||||
return newnode;
|
||||
}
|
||||
|
||||
/*
|
||||
* _copyAppendRelInfo
|
||||
*/
|
||||
@@ -4519,9 +4505,6 @@ copyObject(const void *from)
|
||||
case T_SpecialJoinInfo:
|
||||
retval = _copySpecialJoinInfo(from);
|
||||
break;
|
||||
case T_LateralJoinInfo:
|
||||
retval = _copyLateralJoinInfo(from);
|
||||
break;
|
||||
case T_AppendRelInfo:
|
||||
retval = _copyAppendRelInfo(from);
|
||||
break;
|
||||
|
Reference in New Issue
Block a user