database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

Fix handling of inherited check constraints in ALTER COLUMN TYPE.

Browse Source 
This case got broken in 8.4 by the addition of an error check that
complains if ALTER TABLE ONLY is used on a table that has children.
We do use ONLY for this situation, but it's okay because the necessary
recursion occurs at a higher level.  So we need to have a separate
flag to suppress recursion without making the error check.

Reported and patched by Pavan Deolasee, with some editorial adjustments by
me.  Back-patch to 8.4, since this is a regression of functionality that
worked in earlier branches.
This commit is contained in:
Tom Lane
2012-11-05 13:36:36 -05:00
parent 7e765cb068
commit 4fa38136f7
4 changed files with 62 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/backend/commands/tablecmds.c
View File

@ -291,11 +291,11 @@ static void ATExecAddIndex(AlteredTableInfo *tab, Relation rel,
IndexStmt *stmt, bool is_rebuild);
static void ATExecAddConstraint(List **wqueue,
AlteredTableInfo *tab, Relation rel,
Node *newConstraint, bool recurse);
Node *newConstraint, bool recurse, bool is_readd);
static void ATAddCheckConstraint(List **wqueue,
AlteredTableInfo *tab, Relation rel,
Constraint *constr,
bool recurse, bool recursing);
bool recurse, bool recursing, bool is_readd);
static void ATAddForeignKeyConstraint(AlteredTableInfo *tab, Relation rel,
FkConstraint *fkconstraint);
static void ATExecDropConstraint(Relation rel, const char *constrName,
@ -2559,10 +2559,13 @@ ATExecCmd(List **wqueue, AlteredTableInfo *tab, Relation rel,
ATExecAddIndex(tab, rel, (IndexStmt *) cmd->def, true);
break;
case AT_AddConstraint: /* ADD CONSTRAINT */
ATExecAddConstraint(wqueue, tab, rel, cmd->def, false);
ATExecAddConstraint(wqueue, tab, rel, cmd->def, false, false);
break;
case AT_AddConstraintRecurse: /* ADD CONSTRAINT with recursion */
ATExecAddConstraint(wqueue, tab, rel, cmd->def, true);
ATExecAddConstraint(wqueue, tab, rel, cmd->def, true, false);
break;
case AT_ReAddConstraint: /* Re-add pre-existing check constraint */
ATExecAddConstraint(wqueue, tab, rel, cmd->def, false, true);
break;
case AT_DropConstraint: /* DROP CONSTRAINT */
ATExecDropConstraint(rel, cmd->name, cmd->behavior, false, false);
@ -4309,7 +4312,7 @@ ATExecAddIndex(AlteredTableInfo *tab, Relation rel,
*/
static void
ATExecAddConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel,
Node *newConstraint, bool recurse)
Node *newConstraint, bool recurse, bool is_readd)
{
switch (nodeTag(newConstraint))
{
@ -4327,7 +4330,7 @@ ATExecAddConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel,
{
case CONSTR_CHECK:
ATAddCheckConstraint(wqueue, tab, rel,
constr, recurse, false);
constr, recurse, false, is_readd);
break;
default:
elog(ERROR, "unrecognized constraint type: %d",
@ -4387,10 +4390,18 @@ ATExecAddConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel,
* AddRelationNewConstraints would normally assign different names to the
* child constraints. To fix that, we must capture the name assigned at
* the parent table and pass that down.
*
* When re-adding a previously existing constraint (during ALTER COLUMN TYPE),
* we don't need to recurse here, because recursion will be carried out at a
* higher level; the constraint name issue doesn't apply because the names
* have already been assigned and are just being re-used. We need a separate
* "is_readd" flag for that; just setting recurse=false would result in an
* error if there are child tables.
*/
static void
ATAddCheckConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel,
Constraint *constr, bool recurse, bool recursing)
Constraint *constr, bool recurse, bool recursing,
bool is_readd)
{
List *newcons;
ListCell *lcon;
@ -4449,6 +4460,13 @@ ATAddCheckConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel,
if (newcons == NIL)
return;
/*
* Also, in a re-add operation, we don't need to recurse (that will be
* handled at higher levels).
*/
if (is_readd)
return;
/*
* Propagate to children as appropriate. Unlike most other ALTER
* routines, we have to do this one level of recursion at a time; we can't
@ -4481,7 +4499,7 @@ ATAddCheckConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel,
/* Recurse to child */
ATAddCheckConstraint(wqueue, childtab, childrel,
constr, recurse, true);
constr, recurse, true, is_readd);
heap_close(childrel, NoLock);
}
@ -6057,6 +6075,10 @@ ATPostAlterTypeParse(char *cmd, List **wqueue)
/*
* Attach each generated command to the proper place in the work queue.
* Note this could result in creation of entirely new work-queue entries.
*
* Also note that we have to tweak the command subtypes, because it turns
* out that re-creation of indexes and constraints has to act a bit
* differently from initial creation.
*/
foreach(list_item, querytree_list)
{
@ -6100,6 +6122,7 @@ ATPostAlterTypeParse(char *cmd, List **wqueue)
lappend(tab->subcmds[AT_PASS_OLD_INDEX], cmd);
break;
case AT_AddConstraint:
cmd->subtype = AT_ReAddConstraint;
tab->subcmds[AT_PASS_OLD_CONSTR] =
lappend(tab->subcmds[AT_PASS_OLD_CONSTR], cmd);
break;