database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-13 14:22:43 +03:00
Code Activity

Be more careful to avoid including system headers after perl.h

Browse Source 
Commit 121d2d3d70 included simd.h into pg_wchar.h. This caused a problem
on Windows, since Perl has "#define free" (referring to globals), which
breaks the Windows' header. To fix, move the static inline function
definitions from plperl_helpers.h, into plperl.h, where we already
document the necessary inclusion order. Since those functions were the
only reason for the existence of plperl_helpers.h, remove it.

First reported by Justin Pryzby

Diagnosis and review by Andres Freund, patch by myself per suggestion
from Tom Lane

Discussion: https://www.postgresql.org/message-id/20220826115546.GE2342%40telsasoft.com
This commit is contained in:
John Naylor
2022-08-27 11:17:36 +07:00
parent 52144b6fcd
commit 4eec2e03c3
8 changed files with 171 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/pl/plperl/plperl.c
View File

@@ -23,7 +23,6 @@
#include "commands/trigger.h"
#include "executor/spi.h"
#include "funcapi.h"
#include "mb/pg_wchar.h"
#include "miscadmin.h"
#include "nodes/makefuncs.h"
#include "parser/parse_type.h"
@@ -47,7 +46,6 @@
/* string literal macros defining chunks of perl code */
#include "perlchunks.h"
#include "plperl.h"
#include "plperl_helpers.h"
/* defines PLPERL_SET_OPMASK */
#include "plperl_opmask.h"