database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-24 09:27:52 +03:00
Code Activity

Fix parallel-safety check of expressions and predicate for index builds

Browse Source 
As coded, the planner logic that calculates the number of parallel
workers to use for a parallel index build uses expressions and
predicates from the relcache, which are flattened for the planner by
eval_const_expressions().

As reported in the bug, an immutable parallel-unsafe function flattened
in the relcache would become a Const, which would be considered as
parallel-safe, even if the predicate or the expressions including the
function are not safe in parallel workers.  Depending on the expressions
or predicate used, this could cause the parallel build to fail.

Tests are included that check parallel index builds with parallel-unsafe
predicate and expressions.  Two routines are added to lsyscache.h to be
able to retrieve expressions and predicate of an index from its pg_index
data.

Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Jian He, Michael Paquier
Discussion: https://postgr.es/m/CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com
Backpatch-through: 12
This commit is contained in:
Michael Paquier
2024-03-06 17:24:05 +09:00
parent 8870c54d8a
commit 4ec8f7708b
5 changed files with 121 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/optimizer/plan/planner.c
View File

@@ -6695,10 +6695,18 @@ plan_create_index_workers(Oid tableOid, Oid indexOid)
* Currently, parallel workers can't access the leader's temporary tables.
* Furthermore, any index predicate or index expressions must be parallel
* safe.
*
* Fetch the list of expressions and predicates directly from the
* catalogs. Retrieving this information from the relcache would cause
* the expressions and predicates to be flattened, losing properties that
* can be important to check if parallel workers can be used. For
* example, immutable parallel-unsafe functions, that cannot be used in
* parallel workers, would be changed to Const nodes, that are safe in
* parallel workers.
*/
if (heap->rd_rel->relpersistence == RELPERSISTENCE_TEMP ||
!is_parallel_safe(root, (Node *) RelationGetIndexExpressions(index)) ||
!is_parallel_safe(root, (Node *) RelationGetIndexPredicate(index)))
!is_parallel_safe(root, (Node *) get_index_expressions(indexOid)) ||
!is_parallel_safe(root, (Node *) get_index_predicate(indexOid)))
{
parallel_workers = 0;
goto done;