From 4ea5cf403824e98932aa17c1c00f9c5241daf89d Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 20 Jan 2020 12:57:17 -0500 Subject: [PATCH] Fix pg_dump's sigTermHandler() to use _exit() not exit(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (pg_dump itself installs no atexit handlers, but e.g. OpenSSL does.) That led to crashes or lockups when attempting to terminate a parallel dump or restore via a signal. Fix by calling _exit() instead. Per bug #16199 from Raúl Marín. Back-patch to all supported branches. Discussion: https://postgr.es/m/16199-cb2f121146a96f9b@postgresql.org --- src/bin/pg_dump/parallel.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/bin/pg_dump/parallel.c b/src/bin/pg_dump/parallel.c index 37f0d0d39a7..ba31ac8ed72 100644 --- a/src/bin/pg_dump/parallel.c +++ b/src/bin/pg_dump/parallel.c @@ -611,8 +611,11 @@ sigTermHandler(SIGNAL_ARGS) write_stderr("terminated by user\n"); } - /* And die. */ - exit(1); + /* + * And die, using _exit() not exit() because the latter will invoke atexit + * handlers that can fail if we interrupted related code. + */ + _exit(1); } /*