mirror of
https://github.com/postgres/postgres.git
synced 2025-07-26 01:22:12 +03:00
Fix decoding of speculative aborts.
During decoding for speculative inserts, we were relying for cleaning toast hash on confirmation records or next change records. But that could lead to multiple problems (a) memory leak if there is neither a confirmation record nor any other record after toast insertion for a speculative insert in the transaction, (b) error and assertion failures if the next operation is not an insert/update on the same table. The fix is to start queuing spec abort change and clean up toast hash and change record during its processing. Currently, we are queuing the spec aborts for both toast and main table even though we perform cleanup while processing the main table's spec abort record. Later, if we have a way to distinguish between the spec abort record of toast and the main table, we can avoid queuing the change for spec aborts of toast tables. Reported-by: Ashutosh Bapat Author: Dilip Kumar Reviewed-by: Amit Kapila Backpatch-through: 9.6, where it was introduced Discussion: https://postgr.es/m/CAExHW5sPKF-Oovx_qZe4p5oM6Dvof7_P+XgsNAViug15Fm99jA@mail.gmail.com
This commit is contained in:
@ -46,10 +46,10 @@ typedef struct ReorderBufferTupleBuf
|
||||
* changes. Users of the decoding facilities will never see changes with
|
||||
* *_INTERNAL_* actions.
|
||||
*
|
||||
* The INTERNAL_SPEC_INSERT and INTERNAL_SPEC_CONFIRM changes concern
|
||||
* "speculative insertions", and their confirmation respectively. They're
|
||||
* used by INSERT .. ON CONFLICT .. UPDATE. Users of logical decoding don't
|
||||
* have to care about these.
|
||||
* The INTERNAL_SPEC_INSERT and INTERNAL_SPEC_CONFIRM, and INTERNAL_SPEC_ABORT
|
||||
* changes concern "speculative insertions", their confirmation, and abort
|
||||
* respectively. They're used by INSERT .. ON CONFLICT .. UPDATE. Users of
|
||||
* logical decoding don't have to care about these.
|
||||
*/
|
||||
enum ReorderBufferChangeType
|
||||
{
|
||||
@ -63,6 +63,7 @@ enum ReorderBufferChangeType
|
||||
REORDER_BUFFER_CHANGE_INTERNAL_TUPLECID,
|
||||
REORDER_BUFFER_CHANGE_INTERNAL_SPEC_INSERT,
|
||||
REORDER_BUFFER_CHANGE_INTERNAL_SPEC_CONFIRM,
|
||||
REORDER_BUFFER_CHANGE_INTERNAL_SPEC_ABORT,
|
||||
REORDER_BUFFER_CHANGE_TRUNCATE
|
||||
};
|
||||
|
||||
|
Reference in New Issue
Block a user