mirror of
https://github.com/postgres/postgres.git
synced 2025-10-24 01:29:19 +03:00
Refactor reloption handling for index AMs in-core
This reworks the reloption parsing and build of a couple of index AMs by creating new structures for each index AM's options. This split was already done for BRIN, GIN and GiST (which actually has a fillfactor parameter), but not for hash, B-tree and SPGiST which relied on StdRdOptions due to an overlap with the default option set. This saves a couple of bytes for rd_options in each relcache entry with indexes making use of relation options, and brings more consistency between all index AMs. While on it, add a couple of AssertMacro() calls to make sure that utility macros to grab values of reloptions are used with the expected index AM. Author: Nikolay Shaplov Reviewed-by: Amit Langote, Michael Paquier, Álvaro Herrera, Dent John Discussion: https://postgr.es/m/4127670.gFlpRb6XCm@x200m
This commit is contained in:
@@ -16,12 +16,29 @@
|
||||
|
||||
#include "access/itup.h"
|
||||
#include "access/spgist.h"
|
||||
#include "catalog/pg_am_d.h"
|
||||
#include "nodes/tidbitmap.h"
|
||||
#include "storage/buf.h"
|
||||
#include "utils/geo_decls.h"
|
||||
#include "utils/relcache.h"
|
||||
|
||||
|
||||
typedef struct SpGistOptions
|
||||
{
|
||||
int32 varlena_header_; /* varlena header (do not touch directly!) */
|
||||
int fillfactor; /* page fill factor in percent (0..100) */
|
||||
} SpGistOptions;
|
||||
|
||||
#define SpGistGetFillFactor(relation) \
|
||||
(AssertMacro(relation->rd_rel->relkind == RELKIND_INDEX && \
|
||||
relation->rd_rel->relam == SPGIST_AM_OID), \
|
||||
(relation)->rd_options ? \
|
||||
((SpGistOptions *) (relation)->rd_options)->fillfactor : \
|
||||
SPGIST_DEFAULT_FILLFACTOR)
|
||||
#define SpGistGetTargetPageFreeSpace(relation) \
|
||||
(BLCKSZ * (100 - SpGistGetFillFactor(relation)) / 100)
|
||||
|
||||
|
||||
/* Page numbers of fixed-location pages */
|
||||
#define SPGIST_METAPAGE_BLKNO (0) /* metapage */
|
||||
#define SPGIST_ROOT_BLKNO (1) /* root for normal entries */
|
||||
@@ -423,6 +440,11 @@ typedef SpGistDeadTupleData *SpGistDeadTuple;
|
||||
#define GBUF_REQ_NULLS(flags) ((flags) & GBUF_NULLS)
|
||||
|
||||
/* spgutils.c */
|
||||
|
||||
/* reloption parameters */
|
||||
#define SPGIST_MIN_FILLFACTOR 10
|
||||
#define SPGIST_DEFAULT_FILLFACTOR 80
|
||||
|
||||
extern SpGistCache *spgGetCache(Relation index);
|
||||
extern void initSpGistState(SpGistState *state, Relation index);
|
||||
extern Buffer SpGistNewBuffer(Relation index);
|
||||
|
||||
Reference in New Issue
Block a user