database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-09 22:41:56 +03:00
Code Activity

Consistently spell "leakproof" without a hyphen.

Browse Source 
The overwhelming majority of places already did this, but a small
handful of places had a hyphen.

Yugo Nagata.

Discussion: https://postgr.es/m/CAEZATCXnnuORE2BoGwHw2zbtVvsPOLhbfVmEk9GxRzK%2Bx3OW-Q%40mail.gmail.com
This commit is contained in:
Dean Rasheed
2025-01-14 13:50:54 +00:00
parent 2355e51110
commit 4cb560b53f
6 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/src/sgml/catalogs.sgml
View File

@ -6040,7 +6040,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
The function has no side effects. No information about the The function has no side effects. No information about the
arguments is conveyed except via the return value. Any function arguments is conveyed except via the return value. Any function
that might throw an error depending on the values of its arguments that might throw an error depending on the values of its arguments
is not leak-proof. is not leakproof.
</para></entry> </para></entry>
</row> </row>

2
doc/src/sgml/planstats.sgml
View File

@ -740,7 +740,7 @@ EXPLAIN (ANALYZE, TIMING OFF, BUFFERS OFF) SELECT * FROM t WHERE a &lt;= 49 AND
error, in which case this mechanism is invisible in practice. But if the error, in which case this mechanism is invisible in practice. But if the
user is reading from a security-barrier view, then the planner might wish user is reading from a security-barrier view, then the planner might wish
to check the statistics of an underlying table that is otherwise to check the statistics of an underlying table that is otherwise
inaccessible to the user. In that case, the operator should be leak-proof inaccessible to the user. In that case, the operator should be leakproof
or the statistics will not be used. There is no direct feedback about or the statistics will not be used. There is no direct feedback about
that, except that the plan might be suboptimal. If one suspects that this that, except that the plan might be suboptimal. If one suspects that this
is the case, one could try running the query as a more privileged user, is the case, one could try running the query as a more privileged user,

2
doc/src/sgml/rules.sgml
View File

@ -2162,7 +2162,7 @@ CREATE VIEW phone_number WITH (security_barrier) AS
<literal>LEAKPROOF</literal> to be pushed down, as they never receive data <literal>LEAKPROOF</literal> to be pushed down, as they never receive data
from the view. In contrast, a function that might throw an error depending from the view. In contrast, a function that might throw an error depending
on the values received as arguments (such as one that throws an error in the on the values received as arguments (such as one that throws an error in the
event of overflow or division by zero) is not leak-proof, and could provide event of overflow or division by zero) is not leakproof, and could provide
significant information about the unseen rows if applied before the security significant information about the unseen rows if applied before the security
view's row filters. view's row filters.
</para> </para>

4
src/backend/statistics/extended_stats.c
View File

@ -1397,7 +1397,7 @@ statext_is_compatible_clause_internal(PlannerInfo *root, Node *clause,
/* /*
* If there are any securityQuals on the RTE from security barrier * If there are any securityQuals on the RTE from security barrier
* views or RLS policies, then the user may not have access to all the * views or RLS policies, then the user may not have access to all the
* table's data, and we must check that the operator is leak-proof. * table's data, and we must check that the operator is leakproof.
* *
* If the operator is leaky, then we must ignore this clause for the * If the operator is leaky, then we must ignore this clause for the
* purposes of estimating with MCV lists, otherwise the operator might * purposes of estimating with MCV lists, otherwise the operator might
@ -1464,7 +1464,7 @@ statext_is_compatible_clause_internal(PlannerInfo *root, Node *clause,
/* /*
* If there are any securityQuals on the RTE from security barrier * If there are any securityQuals on the RTE from security barrier
* views or RLS policies, then the user may not have access to all the * views or RLS policies, then the user may not have access to all the
* table's data, and we must check that the operator is leak-proof. * table's data, and we must check that the operator is leakproof.
* *
* If the operator is leaky, then we must ignore this clause for the * If the operator is leaky, then we must ignore this clause for the
* purposes of estimating with MCV lists, otherwise the operator might * purposes of estimating with MCV lists, otherwise the operator might

4
src/backend/utils/adt/selfuncs.c
View File

@ -5763,7 +5763,7 @@ examine_simple_variable(PlannerInfo *root, Var *var,
* Check whether it is permitted to call func_oid passing some of the * Check whether it is permitted to call func_oid passing some of the
* pg_statistic data in vardata. We allow this either if the user has SELECT * pg_statistic data in vardata. We allow this either if the user has SELECT
* privileges on the table or column underlying the pg_statistic data or if * privileges on the table or column underlying the pg_statistic data or if
* the function is marked leak-proof. * the function is marked leakproof.
*/ */
bool bool
statistic_proc_security_check(VariableStatData *vardata, Oid func_oid) statistic_proc_security_check(VariableStatData *vardata, Oid func_oid)
@ -5778,7 +5778,7 @@ statistic_proc_security_check(VariableStatData *vardata, Oid func_oid)
return true; return true;
ereport(DEBUG2, ereport(DEBUG2,
(errmsg_internal("not using statistics because function \"%s\" is not leak-proof", (errmsg_internal("not using statistics because function \"%s\" is not leakproof",
get_func_name(func_oid)))); get_func_name(func_oid))));
return false; return false;
} }

2
src/include/catalog/pg_proc.h
View File

@ -61,7 +61,7 @@ CATALOG(pg_proc,1255,ProcedureRelationId) BKI_BOOTSTRAP BKI_ROWTYPE_OID(81,Proce
/* security definer */ /* security definer */
bool prosecdef BKI_DEFAULT(f); bool prosecdef BKI_DEFAULT(f);
/* is it a leak-proof function? */ /* is it a leakproof function? */
bool proleakproof BKI_DEFAULT(f); bool proleakproof BKI_DEFAULT(f);
/* strict with respect to NULLs? */ /* strict with respect to NULLs? */