database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-28 11:55:03 +03:00
Code Activity

Fix failure when a shared tidbitmap has only one page.

Browse Source 
Commit 98e6e89040 made inadequate
provision for the case of a single-page shared tidbitmap.  It
allocate space for a shared PagetableEntry, but failed to
initialize it.

Report by Thomas Munro.  Patch by Dilip Kumar, with some comment
changes by me.

Discussion: http://postgr.es/m/CAEepm=19Cmnfbi-j2Bw-a6yGPeHE1OVhKvvKz9bRBTJGKfGHMA@mail.gmail.com
This commit is contained in:
Robert Haas
2017-04-11 12:03:12 -04:00
parent 28b0478755
commit 4c3b59abf4
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/nodes/tidbitmap.c
View File

@@ -866,12 +866,14 @@ tbm_prepare_shared_iterate(TIDBitmap *tbm)
else if (tbm->status == TBM_ONE_PAGE) else if (tbm->status == TBM_ONE_PAGE)
{ {
/* /*
* In one page mode allocate the space for one pagetable entry and * In one page mode allocate the space for one pagetable entry,
* directly store its index i.e. 0 in page array * initialize it, and directly store its index (i.e. 0) in the
* page array.
*/ */
tbm->dsapagetable = dsa_allocate(tbm->dsa, sizeof(PTEntryArray) + tbm->dsapagetable = dsa_allocate(tbm->dsa, sizeof(PTEntryArray) +
sizeof(PagetableEntry)); sizeof(PagetableEntry));
ptbase = dsa_get_address(tbm->dsa, tbm->dsapagetable); ptbase = dsa_get_address(tbm->dsa, tbm->dsapagetable);
memcpy(ptbase->ptentry, &tbm->entry1, sizeof(PagetableEntry));
ptpages->index[0] = 0; ptpages->index[0] = 0;
} }