Divide functions into three volatility classes (immutable, stable, and

volatile), rather than the old cachable/noncachable distinction.  This
allows indexscan optimizations in many places where we formerly didn't.
Also, add a pronamespace column to pg_proc (it doesn't do anything yet,
however).

src/backend/utils/Gen_fmgrtab.sh

@@ -9,7 +9,7 @@
 #
 #
 # IDENTIFICATION
-#    $Header: /cvsroot/pgsql/src/backend/utils/Attic/Gen_fmgrtab.sh,v 1.21 2002/02/18 23:11:20 petere Exp $
+#    $Header: /cvsroot/pgsql/src/backend/utils/Attic/Gen_fmgrtab.sh,v 1.22 2002/04/05 00:31:28 tgl Exp $
 #
 #-------------------------------------------------------------------------
 
@@ -99,7 +99,7 @@ sed 	-e 's/^.*OID[^=]*=[^0-9]*//' \
 	-e 's/[ 	]*).*$//' | \
 $AWK '
 /^#/		{ print; next; }
-$4 == "12"	{ print; next; }' > $CPPTMPFILE
+$5 == "12"	{ print; next; }' > $CPPTMPFILE
 
 if [ $? -ne 0 ]; then
     cleanup
@@ -232,7 +232,7 @@ $AWK 'BEGIN {
     Bool["f"] = "false"
 }
 { printf ("  { %d, \"%s\", %d, %s, %s, %s },\n"), \
-	$1, $(NF-2), $9, Bool[$8], Bool[$10], $(NF-2)
+	$1, $(NF-2), $10, Bool[$8], Bool[$11], $(NF-2)
 }' $RAWFILE >> "$$-$TABLEFILE"
 
 if [ $? -ne 0 ]; then

src/backend/utils/adt/regproc.c

@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/regproc.c,v 1.64 2001/10/25 05:49:45 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/regproc.c,v 1.65 2002/04/05 00:31:29 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -42,13 +42,13 @@ regprocin(PG_FUNCTION_ARGS)
 	char	   *pro_name_or_oid = PG_GETARG_CSTRING(0);
 	RegProcedure result = InvalidOid;
 	int			matches = 0;
-	ScanKeyData skey[1];
 
 	if (pro_name_or_oid[0] == '-' && pro_name_or_oid[1] == '\0')
 		PG_RETURN_OID(InvalidOid);
 
 	if (pro_name_or_oid[0] >= '0' &&
-		pro_name_or_oid[0] <= '9')
+		pro_name_or_oid[0] <= '9' &&
+		strspn(pro_name_or_oid, "0123456789") == strlen(pro_name_or_oid))
 	{
 		Oid			searchOid;
 
@@ -61,67 +61,33 @@ regprocin(PG_FUNCTION_ARGS)
 			elog(ERROR, "No procedure with oid %s", pro_name_or_oid);
 		matches = 1;
 	}
-	else if (!IsIgnoringSystemIndexes())
-	{
-		Relation	hdesc;
-		Relation	idesc;
-		IndexScanDesc sd;
-		RetrieveIndexResult indexRes;
-		HeapTupleData tuple;
-		Buffer		buffer;
-
-		ScanKeyEntryInitialize(&skey[0], 0x0,
-							   (AttrNumber) 1,
-							   (RegProcedure) F_NAMEEQ,
-							   CStringGetDatum(pro_name_or_oid));
-
-		hdesc = heap_openr(ProcedureRelationName, AccessShareLock);
-		idesc = index_openr(ProcedureNameIndex);
-		sd = index_beginscan(idesc, false, 1, skey);
-
-		while ((indexRes = index_getnext(sd, ForwardScanDirection)))
-		{
-			tuple.t_datamcxt = NULL;
-			tuple.t_data = NULL;
-			tuple.t_self = indexRes->heap_iptr;
-			heap_fetch(hdesc, SnapshotNow, &tuple, &buffer, sd);
-			pfree(indexRes);
-			if (tuple.t_data != NULL)
-			{
-				result = (RegProcedure) tuple.t_data->t_oid;
-				ReleaseBuffer(buffer);
-				if (++matches > 1)
-					break;
-			}
-		}
-
-		index_endscan(sd);
-		index_close(idesc);
-		heap_close(hdesc, AccessShareLock);
-	}
 	else
 	{
-		Relation	proc;
-		HeapScanDesc procscan;
-		HeapTuple	proctup;
+		Relation	hdesc;
+		ScanKeyData skey[1];
+		SysScanDesc	funcscan;
+		HeapTuple	tuple;
 
 		ScanKeyEntryInitialize(&skey[0], 0x0,
 							   (AttrNumber) Anum_pg_proc_proname,
 							   (RegProcedure) F_NAMEEQ,
 							   CStringGetDatum(pro_name_or_oid));
 
-		proc = heap_openr(ProcedureRelationName, AccessShareLock);
-		procscan = heap_beginscan(proc, 0, SnapshotNow, 1, skey);
+		hdesc = heap_openr(ProcedureRelationName, AccessShareLock);
 
-		while (HeapTupleIsValid(proctup = heap_getnext(procscan, 0)))
+		funcscan = systable_beginscan(hdesc, ProcedureNameNspIndex, true,
+									  SnapshotNow, 1, skey);
+
+		while (HeapTupleIsValid(tuple = systable_getnext(funcscan)))
 		{
-			result = proctup->t_data->t_oid;
+			result = (RegProcedure) tuple->t_data->t_oid;
 			if (++matches > 1)
 				break;
 		}
 
-		heap_endscan(procscan);
-		heap_close(proc, AccessShareLock);
+		systable_endscan(funcscan);
+
+		heap_close(hdesc, AccessShareLock);
 	}
 
 	if (matches > 1)

src/backend/utils/adt/sets.c

@@ -10,7 +10,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/Attic/sets.c,v 1.41 2002/03/29 19:06:14 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/Attic/sets.c,v 1.42 2002/04/05 00:31:29 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -61,8 +61,8 @@ SetDefine(char *querystr, Oid elemType)
 							 querystr,	/* sourceCode */
 							 fileName,	/* fileName */
 							 true,		/* trusted */
-							 false,		/* canCache (assume unsafe) */
 							 false,		/* isStrict (irrelevant, no args) */
+							 PROVOLATILE_VOLATILE,	/* assume unsafe */
 							 100,		/* byte_pct */
 							 0, /* perbyte_cpu */
 							 0, /* percall_cpu */

src/backend/utils/cache/lsyscache.c

@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/cache/lsyscache.c,v 1.68 2002/04/02 01:03:07 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/cache/lsyscache.c,v 1.69 2002/04/05 00:31:30 tgl Exp $
  *
  * NOTES
  *	  Eventually, the index information should go through here, too.
@@ -470,19 +470,19 @@ op_hashjoinable(Oid opno, Oid ltype, Oid rtype)
 }
 
 /*
- * op_iscachable
+ * op_volatile
  *
- * Get the proiscachable flag for the operator's underlying function.
+ * Get the provolatile flag for the operator's underlying function.
  */
-bool
-op_iscachable(Oid opno)
+char
+op_volatile(Oid opno)
 {
 	RegProcedure funcid = get_opcode(opno);
 
 	if (funcid == (RegProcedure) InvalidOid)
 		elog(ERROR, "Operator OID %u does not exist", opno);
 
-	return func_iscachable((Oid) funcid);
+	return func_volatile((Oid) funcid);
 }
 
 /*
@@ -613,14 +613,14 @@ get_func_rettype(Oid funcid)
 }
 
 /*
- * func_iscachable
- *		Given procedure id, return the function's proiscachable flag.
+ * func_volatile
+ *		Given procedure id, return the function's provolatile flag.
  */
-bool
-func_iscachable(Oid funcid)
+char
+func_volatile(Oid funcid)
 {
 	HeapTuple	tp;
-	bool		result;
+	char		result;
 
 	tp = SearchSysCache(PROCOID,
 						ObjectIdGetDatum(funcid),
@@ -628,7 +628,7 @@ func_iscachable(Oid funcid)
 	if (!HeapTupleIsValid(tp))
 		elog(ERROR, "Function OID %u does not exist", funcid);
 
-	result = ((Form_pg_proc) GETSTRUCT(tp))->proiscachable;
+	result = ((Form_pg_proc) GETSTRUCT(tp))->provolatile;
 	ReleaseSysCache(tp);
 	return result;
 }

src/backend/utils/cache/syscache.c

@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/cache/syscache.c,v 1.72 2002/03/31 06:26:32 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/cache/syscache.c,v 1.73 2002/04/05 00:31:31 tgl Exp $
  *
  * NOTES
  *	  These routines allow the parser/planner/executor to perform
@@ -304,7 +304,7 @@ static const struct cachedesc cacheinfo[] = {
 			0
 	}},
 	{ProcedureRelationName,		/* PROCNAME */
-		ProcedureNameIndex,
+		ProcedureNameNspIndex,	/* XXX very temporary */
 		0,
 		3,
 		{